[wpt-sync] Sync PR 15513 - Update |active_tree_scopes| etc when shadow root with adoptedStyleSheets is inserted

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P4
normal
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: wptsync, Unassigned)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

(Whiteboard: [wptsync downstream], )

Assignee

Description

4 months ago

Sync web-platform-tests PR 15513 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15513
Details from upstream follow.

Rakina Zata Amni <rakina@chromium.org> wrote:

Update |active_tree_scopes| etc when shadow root with adoptedStyleSheets is inserted

When a shadow root with non-empty |adoptedStyleSheets| is inserted, we
should make sure that the |active_tree_scopes_| list is updated and the
tree scope is marked dirty so that style invalidation & recalc will
work.

Bug: 934340
Change-Id: I365936e4bcc0132c938fe4e200e208abac91d3d9
Reviewed-on: https://chromium-review.googlesource.com/c/1482437
Commit-Queue: Rakina Zata Amni \<rakina@chromium.org>
Reviewed-by: Kent Tamura \<tkent@chromium.org>
Reviewed-by: Anders Hartvoll Ruud \<andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634624}

Assignee

Comment 1

4 months ago
PR 15513 applied with additional changes from upstream: 7266a4200f24ade6c91608ab05a936770c92e2f0
Assignee

Updated

4 months ago
Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core
Assignee

Comment 4

4 months ago
Ran 1 tests and 22 subtests
OK     : 1
FAIL   : 22

New tests that have failures or other problems:
/css/cssom/CSSStyleSheet-constructable.html
    Attaching a shadow root that already has adopted stylesheets work: FAIL
    Re-attaching shadow host and updating attributes work: FAIL
    Re-attaching shadow host with adopted stylesheets work: FAIL

Comment 5

3 months ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/869bf8eca7ef
[wpt PR 15513] - Update |active_tree_scopes| etc when shadow root with adoptedStyleSheets is inserted, a=testonly

Comment 6

3 months ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/df46e8c9bc56
[wpt PR 15513] - Update |active_tree_scopes| etc when shadow root with adoptedStyleSheets is inserted, a=testonly

Comment 7

3 months ago
bugherder
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.