Closed Bug 1530831 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 15513 - Update |active_tree_scopes| etc when shadow root with adoptedStyleSheets is inserted

Categories

(Core :: DOM: CSS Object Model, enhancement, P4)

Product:
Core
Component:
DOM: CSS Object Model
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15513 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15513
Details from upstream follow.

Rakina Zata Amni <rakina@chromium.org> wrote:

Update |active_tree_scopes| etc when shadow root with adoptedStyleSheets is inserted

When a shadow root with non-empty |adoptedStyleSheets| is inserted, we
should make sure that the |active_tree_scopes_| list is updated and the
tree scope is marked dirty so that style invalidation & recalc will
work.

Bug: 934340
Change-Id: I365936e4bcc0132c938fe4e200e208abac91d3d9
Reviewed-on: https://chromium-review.googlesource.com/c/1482437
Commit-Queue: Rakina Zata Amni \<rakina@chromium.org>
Reviewed-by: Kent Tamura \<tkent@chromium.org>
Reviewed-by: Anders Hartvoll Ruud \<andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634624}

PR 15513 applied with additional changes from upstream: 7266a4200f24ade6c91608ab05a936770c92e2f0
Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core
Ran 1 tests and 22 subtests
OK     : 1
FAIL   : 22

New tests that have failures or other problems:
/css/cssom/CSSStyleSheet-constructable.html
    Attaching a shadow root that already has adopted stylesheets work: FAIL
    Re-attaching shadow host and updating attributes work: FAIL
    Re-attaching shadow host with adopted stylesheets work: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/869bf8eca7ef
[wpt PR 15513] - Update |active_tree_scopes| etc when shadow root with adoptedStyleSheets is inserted, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/df46e8c9bc56
[wpt PR 15513] - Update |active_tree_scopes| etc when shadow root with adoptedStyleSheets is inserted, a=testonly

https://hg.mozilla.org/mozilla-central/rev/df46e8c9bc56

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.