Closed Bug 1530832 Opened 6 months ago Closed 6 months ago

Split Parser::classDefinition into smaller chunks.

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: khyperia, Assigned: khyperia)

References

Details

Attachments

(1 file)

Context is the comment on https://phabricator.services.mozilla.com/D21042 - the refactoring is needed to make adding a block not be horribly sad.

Pushed by ahauck@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f5a2a974495b
Refactor classDefinition and replace Maybe::reset() with a block. r=jorendorff

Backed out changeset f5a2a974495b (bug 1530832) by request of khyperia CLOSED TREE

Backout revision https://hg.mozilla.org/integration/autoland/rev/a629da373379c1d549448aff8e23b52b866a6a47

Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=f5a2a974495b77f882ca9aa630a5f11cf1ff2286

Do not have failure logs because I have canceled the jobs on the failed push

:khyperia can you please take a look?

Flags: needinfo?(khyperia)

Clearing ni?: the situation here is that I forgot to push a minor "fix a dumb rebase error" update to phabricator before hitting lando, so the rev that was pushed had a minor bug that would fail tests. So instead of waiting for tests to fail, I asked to pull the patch.

New version of the patch with the minor fix is going through lando now.

Flags: needinfo?(khyperia)
Pushed by ahauck@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c9301ae941a1
Refactor classDefinition and replace Maybe::reset() with a block. r=jorendorff
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.