Closed Bug 1530850 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 15490 - [LayoutNG] Fix inline-level OOFs inside a block-level context.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15490 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15490
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[LayoutNG] Fix inline-level OOFs inside a block-level context.

Previously we considered text-align for inline-level OOFs inside a
block-level context. But we also needed to avoid floats.

This is surprisingly consistent across browsers! However no tests. :(
So fixed and added tests!

Most of the complexity in this patch is making sure the
logical->line->logical coordinate transforms are done correctly.

Bug: 933996
Change-Id: I78207f8b7cba62e9d6f48f087fd5202178b42910
Reviewed-on: https://chromium-review.googlesource.com/c/1480071
Reviewed-by: Aleks Totic \<atotic@chromium.org>
Reviewed-by: Morten Stenshorne \<mstensho@chromium.org>
Commit-Queue: Ian Kilpatrick \<ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634522}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 12 tests
PASS   : 12
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd463e2be011
[wpt PR 15490] - [LayoutNG] Fix inline-level OOFs inside a block-level context., a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/55dcd4b52946
[wpt PR 15490] - [LayoutNG] Fix inline-level OOFs inside a block-level context., a=testonly

https://hg.mozilla.org/mozilla-central/rev/55dcd4b52946

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.