Highlighted Security Value is difficult to read

RESOLVED FIXED in Firefox 68

Status

defect
P3
normal
RESOLVED FIXED
5 months ago
2 months ago

People

(Reporter: davidwalsh, Assigned: lloanalas, Mentored)

Tracking

({good-first-bug})

unspecified
Firefox 68

Firefox Tracking Flags

(firefox68 fixed)

Details

(Whiteboard: good-first-bug)

Attachments

(3 attachments)

It's really difficult to read the value of a highlighted key in the Security pane. A much lighter red/pink would be better.

Quick observation: the "Params" pane's highlighted rows turn the value white

Hi David

Quick observation: the "Params" pane's highlighted rows turn the value white

Thanks for raising this issue! Would highlighting the rows as white similar to the comment help more vs a lighter red/pink colour?

Also I tried to read the value in dark theme and a highlighted row showed a lighter pink, which is ok for me but not sure if you think it can be improved further :)

Flags: needinfo?(dwalsh)

For anyone interested, here are some guidelines:

  1. The Security panel is located in this file.
  2. It makes use of the PropertiesView component which is located in this file to show the properties inside the Security panel.
  3. The values of the properties are rendered in a Tree format through the TreeView component, which is located in this file.

Note that the Params panel is showing properties in a similar fashion too. Investigation can be done by identifying why "the Params pane's highlighted rows turn the value white" while the highlighted rows in the Security panel doesn't behave the same way.

@Honza this can be a good-first-bug :)

Flags: needinfo?(odvarko)

:davidwalsh, thanks for the report!
:tanhengyeow, thanks for the guidelines!

Yes, this is good first bug.

Honza

Flags: needinfo?(odvarko)
Keywords: good-first-bug
Whiteboard: good-first-bug

Hi! I would like to take this issue as my first contribution to Mozilla! I am currently setting up my repository. Can I get back if I need more information?

(In reply to Naaman Saif from comment #5)

Hi! I would like to take this issue as my first contribution to Mozilla!

Done

I am currently setting up my repository. Can I get back if I need more information?

Sure!

Honza

Assignee: nobody → noumansaif
Mentor: odvarko
Status: NEW → ASSIGNED
Priority: -- → P3
Flags: needinfo?(dwalsh)

Hi Naaman, do you still intend to work on this bug, or should I unassign it so others can claim it?

Flags: needinfo?(noumansaif)

Unassigning this bug.

Assignee: noumansaif → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(noumansaif)

If no one is working on this, I'd like to work on it. Unless we're reserving it for new contributors. Thanks :)

Assignee: nobody → lloanalas
Status: NEW → ASSIGNED

I can't seem to replicate this.

https://i.imgur.com/ne6RKQm.png - However, I do see that when I highlight the values, I can't tell if I'm highlighting or not. Its blue on blue. Values on right no longer appear pink either https://i.imgur.com/PQYhVGf.png.

Flags: needinfo?(dwalsh)
Posted image HardToRead.png

Interesting, that panel may have changed.

When I look at the resource listing, however, and there's a blocked item, I see the difficult to read red.

Flags: needinfo?(dwalsh)

It also looks different on production on my end: https://i.imgur.com/SRTxeTx.png when you click on the panel, it changes to white - so it works like we want it to. However, on nightly, it looks slightly different, the values are no longer pink.

When looking at the resource listing, and there's a blocked item, it is difficult to read the pink text.

Before: https://bug1530914.bmoattachments.org/attachment.cgi?id=9063611
Now: https://i.imgur.com/znNx8aQ.png

(In reply to lloan:[lloanalas] from comment #12)

However, on nightly, it looks slightly different, the values are no longer pink.

I reported bug to cover this, see bug 1552110

(In reply to David Walsh :davidwalsh from comment #11)

When I look at the resource listing, however, and there's a blocked item, I see the difficult to read red.

Thanks for reporting this David!
This is the part we should fix in this bug.

Honza

@lloan:

When I look at the resource listing, however, and there's a blocked item, I see the difficult to read red.

STR to see this issue:

  1. Open DevTools select the Network panel
  2. Load http://janodvarko.cz/firebug/tests/601/Issue601.htm
  3. Click the button on the page
  4. Right click on the request and pick Block URL
  5. Click the button on the page again
  6. You should see new blocked request rendered in red
  7. Select the request -> the text should be white, but stays red -> BUG (see David's screenshot in comment #11)

Honza

Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7fdd2abe918b
Highlighted resource information is difficult to read when blocked. r=Honza
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.