Closed Bug 1530936 Opened 1 year ago Closed 1 year ago

Add a `role="main"` attribute to the output element

Categories

(DevTools :: Console, enhancement, P1)

enhancement

Tracking

(firefox67 fixed)

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: nchevobbe, Assigned: E_Carr, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

By removing the button to toggle the filter bar in Bug 1523861, we made it more difficult to navigate to the output for people navigating with the keyboard.

Setting a proper role on the output element should help people access the output more easily.

So in devtools/client/webconsole/components/ConsoleOutput.js#197-202, we should add:

  dom.div({
    className: "webconsole-output",
    role: "main", // This is the added property.

When working on this bug, make sure the role attribute is added in the console markup by using the Browser Toolbox.

(In reply to Nicolas Chevobbe from comment #0)

By removing the button to toggle the filter bar in Bug 1523861, we made it more difficult to navigate to the output for people navigating with the keyboard.

Setting a proper role on the output element should help people access the output more easily.

So in devtools/client/webconsole/components/ConsoleOutput.js#197-202, we should add:

  dom.div({
    className: "webconsole-output",
    role: "main", // This is the added property.

When working on this bug, make sure the role attribute is added in the console markup by using the Browser Toolbox.

Hello again Nicolas, could I please be assigned this bug? Thank you.

Sure Erik, just did :) Thanks for taking this bug!

Assignee: nobody → ecarr3344
Status: NEW → ASSIGNED

Added a role=main attribute to address accessability within the browser console.

Attachment #9047996 - Attachment description: Bug 1530936 - Add a role=main attribute to the output element. r=nchevobbe → Bug 1530936 - Add a role=main attribute to the output element. r=nchevobbe
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1976157b0c74
Add a role=main attribute to the output element. r=nchevobbe
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.