Add a `role="main"` attribute to the output element

RESOLVED FIXED in Firefox 67

Status

enhancement
P1
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: nchevobbe, Assigned: E_Carr, Mentored)

Tracking

({good-first-bug})

Trunk
Firefox 67

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 months ago

By removing the button to toggle the filter bar in Bug 1523861, we made it more difficult to navigate to the output for people navigating with the keyboard.

Setting a proper role on the output element should help people access the output more easily.

So in devtools/client/webconsole/components/ConsoleOutput.js#197-202, we should add:

  dom.div({
    className: "webconsole-output",
    role: "main", // This is the added property.

When working on this bug, make sure the role attribute is added in the console markup by using the Browser Toolbox.

(Assignee)

Comment 1

3 months ago

(In reply to Nicolas Chevobbe from comment #0)

By removing the button to toggle the filter bar in Bug 1523861, we made it more difficult to navigate to the output for people navigating with the keyboard.

Setting a proper role on the output element should help people access the output more easily.

So in devtools/client/webconsole/components/ConsoleOutput.js#197-202, we should add:

  dom.div({
    className: "webconsole-output",
    role: "main", // This is the added property.

When working on this bug, make sure the role attribute is added in the console markup by using the Browser Toolbox.

Hello again Nicolas, could I please be assigned this bug? Thank you.

(Reporter)

Comment 2

3 months ago

Sure Erik, just did :) Thanks for taking this bug!

Assignee: nobody → ecarr3344
(Reporter)

Updated

3 months ago
Status: NEW → ASSIGNED
(Assignee)

Comment 3

3 months ago

Added a role=main attribute to address accessability within the browser console.

Attachment #9047996 - Attachment description: Bug 1530936 - Add a role=main attribute to the output element. r=nchevobbe → Bug 1530936 - Add a role=main attribute to the output element. r=nchevobbe

Comment 4

3 months ago
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1976157b0c74
Add a role=main attribute to the output element. r=nchevobbe

Comment 5

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.