Profiler stats (backend, ipc, compositor, gpu times) are averaged over too many frames

RESOLVED FIXED in Firefox 67

Status

()

defect
P3
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: nical, Assigned: nical)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

4 months ago

This has been bugging me for a while. Averaging over 600 frames means that we need to wait for 10 seconds at 60fps of a stable animation before the numbers show something meaningful. It's is way too long in my opinion.

Assignee

Comment 2

4 months ago

TBH I'm a bit torn between the patch I submitted which is simple but has the counter change every frame which can a be a bit distracting, and using an AverageTimeProfileCounter to display this info instead of using the stats from the ProfileGraph which averages the samples in a way that is nicer to look at.

The large number of frames has also bothered me.

Attachment #9047017 - Attachment is obsolete: true
Assignee

Comment 5

4 months ago

TBH I'm a bit torn between the patch I submitted [...] and using an AverageTimeProfileCounter to display this info instead of using the stats from the ProfileGraph [...].

I ended up switching to the latter BTW.

Comment 6

4 months ago
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ec7068a12a7b
Show profiler stats averaged over half a second instead of 600 frames. r=gw

Comment 7

4 months ago
bugherder
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.