Send custom "marionette-startup-requested" observer notification to start Marionette in Thunderbird

RESOLVED FIXED in Thunderbird 67.0

Status

enhancement
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: whimboo, Assigned: darktrojan)

Tracking

unspecified
Thunderbird 67.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

As of now Marionette listens for a couple of startup observer notifications, and has to wait until the startup recorder has finished recording startup scripts:

https://searchfox.org/mozilla-central/rev/dbddac86aadf1d4871fb350bbe66db43728a9f81/testing/marionette/components/marionette.js#449-456

For Fennec and GeckoView we recently got the marionette-startup-requested observer notification added (see bug 1496773), which allows us to explicitly specify at which stage during startup Marionette has to be enabled.

The same behavior we would like to see for Thunderbird.

Geoff, would you mind to implement that?

Flags: needinfo?(geoff)
Summary: Send custom "marionette-startup-requested" observer notification to start Marionette → Send custom "marionette-startup-requested" observer notification to start Marionette in Thunderbird
Assignee

Comment 1

3 months ago

Let me just check I've understood correctly. You want something in Thunderbird to send marionette-startup-requested so that you don't have to listen for mail-startup-done?

Flags: needinfo?(geoff)

That is exactly correct. In that case the product can define and change the time during startup where to initialize Marionette.

Assignee

Updated

3 months ago
Assignee: nobody → geoff
Status: NEW → ASSIGNED
Assignee

Comment 3

3 months ago
Attachment #9049398 - Flags: review?(mkmelin+mozilla)
Attachment #9049398 - Flags: review?(mkmelin+mozilla) → review+
Assignee

Updated

2 months ago
Keywords: checkin-needed
Version: 52 Branch → unspecified
Assignee

Updated

2 months ago
Keywords: checkin-needed
Assignee

Comment 4

2 months ago
Posted file log.log

This is what happens if I start without changing the m-c code.

So yes, we should land both patches close together if possible to allow an initialization for TB.

Assignee

Comment 7

2 months ago

I'm about to land this on inbound, it'll need the c-c patch to land when it gets to central.

Comment 8

2 months ago

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec939d4f81dc
Stop listening for mail-startup-done to start Marionette in Thunderbird; r=whimboo

Keywords: checkin-needed
Assignee

Updated

2 months ago
Keywords: leave-open

Comment 10

2 months ago

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/1f0d963096cb
Send custom "marionette-startup-requested" observer notification to start Marionette in Thunderbird; r=mkmelin

Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Assignee

Updated

2 months ago
Target Milestone: --- → Thunderbird 67.0
Assignee

Comment 11

2 months ago

Note to self: next time, set checkin-needed after checking in the first part.

Thanks Geoff! Good to see this extra registered observer listener gone.

You need to log in before you can comment on or make changes to this bug.