Closed Bug 1530999 Opened 7 years ago Closed 7 years ago

[wpt-sync] Sync PR 15549 - Fix class_white-space_[normal|pre-line]_wrapped.html wpt/webvtt tests

Categories

(Core :: Audio/Video: Playback, enhancement, P4)

Product:
Core
Component:
Audio/Video: Playback
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15549 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15549
Details from upstream follow.

Sriram <srirama.m@samsung.com> wrote:

Fix class_white-space_[normal|pre-line]_wrapped.html wpt/webvtt tests

These tests are using "white" videos and the rendering is not actually
"white" (the CSS color) used in ref test.
Also the ref test has the font property (sans-serif) applied to the inner span,
so we get a different font for the other span - that font has slightly
different metrics (even though it's still 9px), so over the whole line
this ends up yielding an "extra pixel" in height.

Fixed the ref tests to use the actual \<video> element instead of
white background \<div>, and also fixed the font size issue
by applying font family to parent \<span> element.

BUG=930608, 626703

Change-Id: I44c33a8cda08aff2e8b84f2542cc504866bd4c10

Reviewed-on: https://chromium-review.googlesource.com/1485628
WPT-Export-Revision: 8d1a4963ddb9e4b9d15e97b39a6b47b5293582a7

Component: web-platform-tests → Audio/Video: Playback
Product: Testing → Core
Ran 2 tests Tests that are disabled for instability: /webvtt/rendering/cues-with-video/processing-model/selectors/cue_function/class_object/class_white-space_normal_wrapped.html /webvtt/rendering/cues-with-video/processing-model/selectors/cue_function/class_object/class_white-space_pre-line_wrapped.html
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/1ce3b350ece5 [wpt PR 15549] - Fix class_white-space_[normal|pre-line]_wrapped.html wpt/webvtt tests, a=testonly

https://hg.mozilla.org/mozilla-central/rev/1ce3b350ece5

Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.