Closed Bug 1531008 Opened 1 year ago Closed 1 year ago

Replace makeURI with Services.io.newURI in browser-captivePortal.js

Categories

(Firefox :: General, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: johannh, Assigned: pavithra.e+github, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file)

This is a good first bug for newcomers to Firefox development.

we should replace usage of the deprecated makeURI function with Services.io.newURI in browser-captivePortal.js

The code in question is here: https://searchfox.org/mozilla-central/rev/dbddac86aadf1d4871fb350bbe66db43728a9f81/browser/base/content/browser-captivePortal.js#264

The parameters should stay the same

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

I'd like to work on this bug.

Great, thanks!

Assignee: nobody → pavithra.e+github
Status: NEW → ASSIGNED

Replaced makeURI with Services.io.newURI

Setting checkin-needed to get this landed.

Keywords: checkin-needed

Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/184d162629aa
Replace makeURI with Services.io.newURI r=johannh

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.