Replace makeURI with Services.io.newURI in browser-captivePortal.js

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P5
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: johannh, Assigned: pavithra.e+github, Mentored)

Tracking

(Blocks 1 bug, {good-first-bug})

unspecified
Firefox 67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

3 months ago

This is a good first bug for newcomers to Firefox development.

we should replace usage of the deprecated makeURI function with Services.io.newURI in browser-captivePortal.js

The code in question is here: https://searchfox.org/mozilla-central/rev/dbddac86aadf1d4871fb350bbe66db43728a9f81/browser/base/content/browser-captivePortal.js#264

The parameters should stay the same

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Assignee

Comment 1

3 months ago

I'd like to work on this bug.

Reporter

Comment 2

3 months ago

Great, thanks!

Assignee: nobody → pavithra.e+github
Status: NEW → ASSIGNED
Assignee

Comment 3

3 months ago

Replaced makeURI with Services.io.newURI

Reporter

Comment 4

3 months ago

Setting checkin-needed to get this landed.

Keywords: checkin-needed

Comment 5

3 months ago

Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/184d162629aa
Replace makeURI with Services.io.newURI r=johannh

Keywords: checkin-needed

Comment 6

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.