1531008 - Replace makeURI with Services.io.newURI in browser-captivePortal.js

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P5)

Description

[Johann Hofmann [:johannh]]

This is a good first bug for newcomers to Firefox development.

we should replace usage of the deprecated makeURI function with Services.io.newURI in browser-captivePortal.js

The code in question is here: https://searchfox.org/mozilla-central/rev/dbddac86aadf1d4871fb350bbe66db43728a9f81/browser/base/content/browser-captivePortal.js#264

The parameters should stay the same

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Comment 1

[Pavithra]

I'd like to work on this bug.

Comment 2

[Johann Hofmann [:johannh]]

Great, thanks!

Comment 3

[Pavithra]

Attachment: Bug 1531008: Replace makeURI with Services.io.newURI

Replaced makeURI with Services.io.newURI

Comment 4

[Johann Hofmann [:johannh]]

Setting checkin-needed to get this landed.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/184d162629aa
Replace makeURI with Services.io.newURI r=johannh

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/184d162629aa