1531013 - Replace makeURI with Services.io.newURI in browser-places.js

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P5)

Description

[Johann Hofmann [:johannh]]

This is a good first bug for newcomers to Firefox development.

we should replace usage of the deprecated makeURI function with Services.io.newURI in browser-places.js

The code in question is here: https://searchfox.org/mozilla-central/rev/dbddac86aadf1d4871fb350bbe66db43728a9f81/browser/base/content/browser-places.js#456

The parameters should stay the same

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Comment 1

[shruti10gandotra]

I want to take this up. Thanks!

Comment 2

[mariahajmal]

(In reply to Johann Hofmann [:johannh] from comment #0)
Can you please assign it to me

This is a good first bug for newcomers to Firefox development.

we should replace usage of the deprecated makeURI function with Services.io.newURI in browser-places.js

The code in question is here: https://searchfox.org/mozilla-central/rev/dbddac86aadf1d4871fb350bbe66db43728a9f81/browser/base/content/browser-places.js#456

The parameters should stay the same

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Comment 3

[Karina G]

Hello, I have already built firefox and I would like to work on this :)

Comment 4

[Johann Hofmann [:johannh]]

Sorry, shruti10gandotra was first to ask :)

Comment 5

[shruti10gandotra]

Attachment: Replace usage of the deprecated makeURI function with Services.io.newURI in browser-places.js

Replaced the usage of the deprecated makeURI function with Services.io.newURI in mozilla-central/browser/base/content/browser-places.js.

Comment 6

[Johann Hofmann [:johannh]]

Hi shruti10gandotra,

unfortunately the old Bugzilla review system has been disabled as of today, so you will need to upload a patch with Phabricator. There's a guide on how to get started with Phabricator here: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Thanks!

Comment 7

[shruti10gandotra]

(In reply to Johann Hofmann [:johannh] from comment #6)

Hi shruti10gandotra,

unfortunately the old Bugzilla review system has been disabled as of today, so you will need to upload a patch with Phabricator. There's a guide on how to get started with Phabricator here: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Thanks!
Okay, I will do that.

Comment 8

[shruti10gandotra]

(In reply to Johann Hofmann [:johannh] from comment #6)
I have submitted the patch with phabricator.

Hi shruti10gandotra,

unfortunately the old Bugzilla review system has been disabled as of today, so you will need to upload a patch with Phabricator. There's a guide on how to get started with Phabricator here: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Thanks!

Comment 9

[shruti10gandotra]

Attachment: Bug 1531013: Replace makeURI with Services.io.newURI in browser-places.js

Comment 10

[shruti10gandotra]

(In reply to shruti10gandotra from comment #7)
Here's the link to the patch with phabricator: https://phabricator.services.mozilla.com/D21668

(In reply to Johann Hofmann [:johannh] from comment #6)

Hi shruti10gandotra,

unfortunately the old Bugzilla review system has been disabled as of today, so you will need to upload a patch with Phabricator. There's a guide on how to get started with Phabricator here: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Thanks!
Okay, I will do that.

Comment 11

[Johann Hofmann [:johannh]]

Let's get this checked in

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/578e042ec884
Replace makeURI with Services.io.newURI in browser-places.js r=johannh

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/578e042ec884

Comment 14

[shruti10gandotra]

Thanks for adding it