Closed Bug 1531013 Opened 9 months ago Closed 8 months ago

Replace makeURI with Services.io.newURI in browser-places.js

Categories

(Firefox :: General, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: johannh, Assigned: shruti10gandotra, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(1 file, 1 obsolete file)

This is a good first bug for newcomers to Firefox development.

we should replace usage of the deprecated makeURI function with Services.io.newURI in browser-places.js

The code in question is here: https://searchfox.org/mozilla-central/rev/dbddac86aadf1d4871fb350bbe66db43728a9f81/browser/base/content/browser-places.js#456

The parameters should stay the same

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

I want to take this up. Thanks!

(In reply to Johann Hofmann [:johannh] from comment #0)
Can you please assign it to me

This is a good first bug for newcomers to Firefox development.

we should replace usage of the deprecated makeURI function with Services.io.newURI in browser-places.js

The code in question is here: https://searchfox.org/mozilla-central/rev/dbddac86aadf1d4871fb350bbe66db43728a9f81/browser/base/content/browser-places.js#456

The parameters should stay the same

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Hello, I have already built firefox and I would like to work on this :)

Sorry, shruti10gandotra was first to ask :)

Assignee: nobody → shruti10gandotra
Status: NEW → ASSIGNED

Replaced the usage of the deprecated makeURI function with Services.io.newURI in mozilla-central/browser/base/content/browser-places.js.

Attachment #9047268 - Flags: review+

Hi shruti10gandotra,

unfortunately the old Bugzilla review system has been disabled as of today, so you will need to upload a patch with Phabricator. There's a guide on how to get started with Phabricator here: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Thanks!

(In reply to Johann Hofmann [:johannh] from comment #6)

Hi shruti10gandotra,

unfortunately the old Bugzilla review system has been disabled as of today, so you will need to upload a patch with Phabricator. There's a guide on how to get started with Phabricator here: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Thanks!
Okay, I will do that.

(In reply to Johann Hofmann [:johannh] from comment #6)
I have submitted the patch with phabricator.

Hi shruti10gandotra,

unfortunately the old Bugzilla review system has been disabled as of today, so you will need to upload a patch with Phabricator. There's a guide on how to get started with Phabricator here: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Thanks!

Attachment #9047268 - Attachment is obsolete: true

(In reply to shruti10gandotra from comment #7)
Here's the link to the patch with phabricator: https://phabricator.services.mozilla.com/D21668

(In reply to Johann Hofmann [:johannh] from comment #6)

Hi shruti10gandotra,

unfortunately the old Bugzilla review system has been disabled as of today, so you will need to upload a patch with Phabricator. There's a guide on how to get started with Phabricator here: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Thanks!
Okay, I will do that.

Let's get this checked in

Keywords: checkin-needed

Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/578e042ec884
Replace makeURI with Services.io.newURI in browser-places.js r=johannh

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67

Thanks for adding it

You need to log in before you can comment on or make changes to this bug.