Closed Bug 1531035 Opened 2 years ago Closed 2 years ago

Null weakmap keys should not be allowed

Categories

(Core :: JavaScript: GC, enhancement, P3)

Product:
Core
Component:
JavaScript: GC
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

bug1531035-check-weakmap-keys
4.16 KB, patch
sfink
: review+
Details | Diff | Splinter Review

We currently assume weakmap keys are non-null pointers, but we don't check this anywhere.

Patch to make the HashMap base class of WeakMap private and add versions of put() and relookupOrAdd() that check the key is not null.

Attachment #9047067 - Flags: review?(sphink)
Attachment #9047067 - Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1edf55d690f2
Assert that weak map keys are not null r=sfink

https://hg.mozilla.org/mozilla-central/rev/1edf55d690f2

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox67: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.