Stop preprocessing chat files that ifdef Thunderbird vs. Instantbird

RESOLVED FIXED in Instantbird 67

Status

enhancement
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: clokep, Assigned: clokep)

Tracking

trunk
Instantbird 67
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

A few of our files had different behavior based on whether they were in Instantbird or Thunderbird. This is longer necessary and can be simplified.

Posted patch Patch v1 (obsolete) — Splinter Review

I connected some accounts, clicked through the account wizard and such and didn't see any issues.

Assignee: nobody → clokep
Status: NEW → ASSIGNED
Attachment #9047110 - Flags: review?(florian)
Comment on attachment 9047110 [details] [diff] [review]
Patch v1

Review of attachment 9047110 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but I'm not convinced bitrotting bug 1506529 is a good idea.

::: chat/content/imtooltip.xml
@@ -455,5 @@
> -         if (localName == "buddy")
> -           return updateTooltipFromBuddy(elt.buddy.preferredAccountBuddy);
> -
> -         if (localName == "contact")
> -           return updateTooltipFromContact(elt.contact);

Is this method becoming dead code?

Bug 1531741 partially handled this.

Posted patch Patch v2Splinter Review

This now ignores imtooltip.xml and imTextboxUtils.jsm is no longer preprocessed, so this got slimmed way down.

Attachment #9047110 - Attachment is obsolete: true
Attachment #9047110 - Flags: review?(florian)
Attachment #9047829 - Flags: review?(florian)
Comment on attachment 9047829 [details] [diff] [review]
Patch v2

Review of attachment 9047829 [details] [diff] [review]:
-----------------------------------------------------------------

We should get rid of our uses of the hidden window, but that's for another bug.
Attachment #9047829 - Flags: review?(florian) → review+

Pushed by clokep@gmail.com:
https://hg.mozilla.org/comm-central/rev/619c9cb3842e
Stop preprocessing chat files for Thunderbird. r=florian

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 67
You need to log in before you can comment on or make changes to this bug.