1531067 - Stop preprocessing chat files that ifdef Thunderbird vs. Instantbird

Status: RESOLVED FIXED

(Chat Core :: General, enhancement)

Description

[Patrick Cloke [:clokep]]

A few of our files had different behavior based on whether they were in Instantbird or Thunderbird. This is longer necessary and can be simplified.

Comment 1

[Patrick Cloke [:clokep]]

Attachment: Patch v1

I connected some accounts, clicked through the account wizard and such and didn't see any issues.

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 9047110 [details] [diff] [review]
Patch v1

Review of attachment 9047110 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, but I'm not convinced bitrotting bug 1506529 is a good idea.

::: chat/content/imtooltip.xml
@@ -455,5 @@
> -         if (localName == "buddy")
> -           return updateTooltipFromBuddy(elt.buddy.preferredAccountBuddy);
> -
> -         if (localName == "contact")
> -           return updateTooltipFromContact(elt.contact);

Is this method becoming dead code?

Comment 3

[Patrick Cloke [:clokep]]

Bug 1531741 partially handled this.

Comment 4

[Patrick Cloke [:clokep]]

Attachment: Patch v2

This now ignores imtooltip.xml and imTextboxUtils.jsm is no longer preprocessed, so this got slimmed way down.

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 9047829 [details] [diff] [review]
Patch v2

Review of attachment 9047829 [details] [diff] [review]:
-----------------------------------------------------------------

We should get rid of our uses of the hidden window, but that's for another bug.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/619c9cb3842e
Stop preprocessing chat files for Thunderbird. r=florian