1531082 - Marionette test requires Internet connection to run?

Status: RESOLVED INCOMPLETE

(Remote Protocol :: Marionette, defect, P3)

Description

[Botond Ballo [:botond]]

I tried to run an Marionette test on the Android emulator while on a flight (with no internet access). It failed with the following exception:

W System.err: java.net.UnknownHostException: Unable to resolve host "firefox.settings.services.mozilla.com": No address associated with hostname
W System.err:    at java.net.Inet6AddressImpl.lookupHostByName(Inet6AddressImpl.java:125)
W System.err:    at java.net.Inet6AddressImpl.lookupAllHostAddr(Inet6AddressImpl.java:74)
W System.err:    at java.net.InetAddress.getAllByName(InetAddress.java:752)
W System.err:    at com.android.okhttp.internal.Network$1.resolveInetAddresses(Network.java:29)
W System.err:    at com.android.okhttp.internal.http.RouteSelector.resetNextInetSocketAddress(RouteSelector.java:187)
W System.err:    at com.android.okhttp.internal.http.RouteSelector.nextProxy(RouteSelector.java:156)
W System.err:    at com.android.okhttp.internal.http.RouteSelector.next(RouteSelector.java:98)
W System.err:    at com.android.okhttp.internal.http.HttpEngine.createNextConnection(HttpEngine.java:345)
W System.err:    at com.android.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:328)
W System.err:    at com.android.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:246)
W System.err:    at com.android.okhttp.internal.huc.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:457)
W System.err:    at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getResponse(HttpURLConnectionImpl.java:405)
W System.err:    at com.android.okhttp.internal.huc.HttpURLConnectionImpl.getInputStream(HttpURLConnectionImpl.java:243)
W System.err:    at com.android.okhttp.internal.huc.DelegatingHttpsURLConnection.getInputStream(DelegatingHttpsURLConnection.java:210)
W System.err:    at com.android.okhttp.internal.huc.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java)
W System.err:    at org.mozilla.gecko.switchboard.SwitchBoard.readFromUrlGET(SwitchBoard.java:442)
W System.err:    at org.mozilla.gecko.switchboard.SwitchBoard.loadConfig(SwitchBoard.java:119)
W System.err:    at org.mozilla.gecko.switchboard.AsyncConfigLoader.doInBackground(AsyncConfigLoader.java:54)
W System.err:    at org.mozilla.gecko.BrowserApp$9.doInBackground(BrowserApp.java:893)
W System.err:    at org.mozilla.gecko.BrowserApp$9.doInBackground(BrowserApp.java:890)
W System.err:    at android.os.AsyncTask$2.call(AsyncTask.java:304)
W System.err:    at java.util.concurrent.FutureTask.run(FutureTask.java:237)
W System.err:    at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:243)
W System.err:    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
W System.err:    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
W System.err:    at java.lang.Thread.run(Thread.java:761)
W System.err: Caused by: android.system.GaiException: android_getaddrinfo failed: EAI_NODATA (No address associated with hostname)
W System.err:    at libcore.io.Posix.android_getaddrinfo(Native Method)
W System.err:    at libcore.io.ForwardingOs.android_getaddrinfo(ForwardingOs.java:55)
W System.err:    at java.net.Inet6AddressImpl.lookupHostByName(Inet6AddressImpl.java:106)
W System.err:    ... 25 more

Note, the emulator was already downloaded and set up.

Do Marionette tests require an active internet connection for local runs? If so, can this requirement be avoided?

Comment 1

[Andreas Tolfsen ❲:ato❳]

This appears to be an error originating from
org.mozilla.gecko.switchboard.AsyncConfigLoader.doInBackground
and not Marionette. Is this Fennec? Fenix/GeckoView?

(As somewhat of a digression, we do have a lot of tests that depend
on having an internet connection for no good reason. The cases
where a test explicitly requests something from a remote host is
easy to fix, but my experience has been that it’s more challenging
to correctly instrument the browser in a way that it avoid pinging
remote services. See https://bugzilla.mozilla.org/show_bug.cgi?id=1272255
for a bit more discussion on this topic. Again, this isn’t related
to this bug.)

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Not sure what kind of service that is. But if it is not needed we should set services.settings.server to a dummy URL for Fennec only.

Comment 3

[Botond Ballo [:botond]]

(In reply to Andreas Tolfsen ⦗:ato⦘ from comment #1)

This appears to be an error originating from
org.mozilla.gecko.switchboard.AsyncConfigLoader.doInBackground
and not Marionette. Is this Fennec? Fenix/GeckoView?

Fennec. The test harness hangs after this error, so I assume it's the cause.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mind adding the above mentioned preference from comment 2 to the following list, and check if that works?

https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/testing/marionette/client/marionette_driver/geckoinstance.py#377

Comment 5

[Botond Ballo [:botond]]

Attachment: Output from `mach marionette test`

At the moment, I can't even get a marionette test to run successfully with an Internet connection (getting the attached output).

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

You have to use mach marionette-test to run the tests. marionette test was obsolete and I removed it recently.

Comment 7

[Botond Ballo [:botond]]

What should I set as the value of the services.settings.server pref?

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Something similar to https://searchfox.org/mozilla-central/rev/56705678f5fc363be5e0237e1686f619b0d23009/testing/marionette/client/marionette_driver/geckoinstance.py#136

Comment 9

[Botond Ballo [:botond]]

Attachment: Output from `mach marionette-test`

Comment 10

[Botond Ballo [:botond]]

Attachment: Patch to set pref

Above is the output from mach marionette-test after setting the mentioned pref.

And, for completeness, here is the patch I used to set the pref.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 9054631 [details] [diff] [review]
Patch to set pref

Review of attachment 9054631 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/client/marionette_driver/geckoinstance.py
@@ +397,5 @@
>          # open additional tabs, the test harness tab itself might get unloaded
>          "browser.tabs.disableBackgroundZombification": True,
> +
> +        # Ensure blocklist updates don't hit the network
> +        "services.settings.server": "http://%(server)s/dummy/blocklist/",

This preference already gets set in the base GeckoInstance class, which is inherited by the Fennec specific one. So this addition shouldn't cause any difference in behavior.

Comment 12

[Botond Ballo [:botond]]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #11)

::: testing/marionette/client/marionette_driver/geckoinstance.py
@@ +397,5 @@

     # open additional tabs, the test harness tab itself might get unloaded
     "browser.tabs.disableBackgroundZombification": True,

•    # Ensure blocklist updates don't hit the network
  

•    "services.settings.server": "http://%(server)s/dummy/blocklist/",
  

This preference already gets set in the base GeckoInstance class, which is
inherited by the Fennec specific one. So this addition shouldn't cause any
difference in behavior.

Perhaps I misunderstood your suggestion from comment 4, then:

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #4)

Mind adding the above mentioned preference from comment 2 to the following list, and check if that works?

https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/testing/marionette/client/marionette_driver/geckoinstance.py#377

Did you have something different in mind?

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Botond Ballo [:botond] from comment #12)

This preference already gets set in the base GeckoInstance class, which is
inherited by the Fennec specific one. So this addition shouldn't cause any
difference in behavior.

Perhaps I misunderstood your suggestion from comment 4, then:

Sorry, but that was my fault. I didn't check the base class at that point.

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #4)

Mind adding the above mentioned preference from comment 2 to the following list, and check if that works?

https://dxr.mozilla.org/mozilla-central/rev/c2593a3058afdfeaac5c990e18794ee8257afe99/testing/marionette/client/marionette_driver/geckoinstance.py#377

Did you have something different in mind?

I actually see that the reason is Content process crashed (from your log in comment 5). Mind commenting out all MOZ_CRASHREPORTER_* env variables which get set by Marionette?

Also do you see the same behavior when not running a mobile but desktop build?

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

No more activity in the last 3 years. I'm going to close. Feel free to reopen if it is still the case.