Closed Bug 1531091 Opened 7 months ago Closed 6 months ago

Don't drop Unicode extension keys without values when resolving locales

Categories

(Core :: JavaScript: Internationalization API, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox67 --- wontfix
firefox68 --- fixed

People

(Reporter: Waldo, Assigned: anba)

References

Details

Attachments

(1 file)

Change from https://github.com/tc39/ecma402/issues/223 with test modified in https://github.com/tc39/ecma402/pull/302 and as soon as I update test262 enough, we'll be failing this test. Filing now to get a bug number to add to the jstests.list skip-entry.

  • Implement the spec changes from https://github.com/tc39/ecma402/pull/302.
  • Additionally for the test262 test to pass, we also need to implement parts of
    the Unicode extension canonicalisation from bug 1522070. Namely removing the
    value "true" from keywords.
  • The two helper functions were copied from the Intl.Locale patch.
  • CanonicalizeUnicodeExtension was slightly modified to allow duplicate
    keywords, which is required by spec.
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Keywords: checkin-needed

Pushed by aiakab@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/82630420613d
Append Unicode extensions without values and remove "true" value from keywords. r=jwalden

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Regressions: 1572985
You need to log in before you can comment on or make changes to this bug.