Open Bug 1531095 Opened 2 years ago Updated 2 years ago

Don't need to load SafeBrowsing V4 metadata files every time

Categories

(Toolkit :: Safe Browsing, enhancement, P3)

enhancement

Tracking

()

People

(Reporter: dimi, Unassigned)

References

Details

(Keywords: good-first-bug, Whiteboard: [qf-])

The LookupCacheV4::LoadMetadata opens the .metadata file every time. But we can actually keep the "state" and "hash" in memory after receiving an update.
So we don't need to load the file again next time.

Could this be an issue that I can possibly be assigned to? would love to work on it.

Depends on: 1353956

(In reply to Victor from comment #1)

Could this be an issue that I can possibly be assigned to? would love to work on it.

Hi Victor,
Sure, it will be great if you can help!
We will have to wait for Bug 1353956 first, then we can work on this.

Whiteboard: [qf]

Performance triage: for now, we're assuming this is [qf:p1:pageload] like its dependency Bug 1353956.

Whiteboard: [qf] → [qf:p1:pageload]

(In reply to Daniel Holbert [:dholbert] from comment #3)

Performance triage: for now, we're assuming this is [qf:p1:pageload] like its dependency Bug 1353956.

I guess this probably won't affect the pageload. It only improves the performance a little bit for SafeBrowsing update after the first time. SafeBrowsing update happens every 45mins in the background and this is a small file without any integrity check after loading.

I set the dependence because we change some stuff in the Bug 1353956 and this depends on code in the patch.

Ok, thanks for clarifying. Sounds like this is [qf-] then (doesn't need perf team visibility/push), since it's just a small improvement to runtime of an already short & infrequent background task.

Whiteboard: [qf:p1:pageload] → [qf-]

Is anybody working on this? If yes, please reply.

You need to log in before you can comment on or make changes to this bug.