1531101 - Display a message about being in Picture-in-Picture mode in the original video

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, enhancement, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

When a video is put into Picture-in-Picture, we expect that the original <video> element should display a message saying that the <video> is in Picture-in-Picture.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1531101 - Add method for stopping visual cloning of a video, and a read-only property to check cloning state. r?jya,ehsan

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1531101 - Get rid of some dead CSS in videocontrols.css. r?jaws

Depends on D22161

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1531101 - Update videocontrols error IDs to make it cleaner to introduce new message types. r?jaws

Depends on D22162

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Hi jya - is ehsan's review sufficient for https://phabricator.services.mozilla.com/D22160?

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1531101 - When the PictureInPicture window closes, stop cloning immediately to update the original video UAWidget. r?felipe

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1531101 - Add strings, styles and mark-up for Picture-in-Picture message for a video with controls. r?jaws

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1531101 - Fire UAWidget setup / change events when starting or stopping a visual clone of a <video> element. r?jya

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13a0c61ed4fc
Add method for stopping visual cloning of a video, and a read-only property to check cloning state. r=jya,Ehsan
https://hg.mozilla.org/integration/autoland/rev/5887b55233c2
Fire UAWidget setup / change events when starting or stopping a visual clone of a <video> element. r=jya
https://hg.mozilla.org/integration/autoland/rev/12bcda2d76db
Get rid of some dead CSS in videocontrols.css. r=jaws
https://hg.mozilla.org/integration/autoland/rev/4a4b44c3481a
Update videocontrols error IDs to make it cleaner to introduce new message types. r=jaws
https://hg.mozilla.org/integration/autoland/rev/44d96bcc51f7
Add strings, styles and mark-up for Picture-in-Picture message for a video with controls. r=jaws
https://hg.mozilla.org/integration/autoland/rev/10e9bbf2d1df
When the PictureInPicture window closes, stop cloning immediately to update the original video UAWidget. r=Felipe

Comment 9

[Dorel Luca [:dluca]]

Backed out 6 changesets (bug 1531101) for Mochitest failure in toolkit/content/tests/widgets/test_videocontrols_error.html. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=233250450&repo=autoland&lineNumber=36293

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=10e9bbf2d1df3b261a86356d3e9e15da962a9568

Backout:
https://hg.mozilla.org/integration/autoland/rev/b9b0378c5e0bd749b7904c2a5ccca74c9683bf42

Comment 10

[Mike Conley (:mconley) (:⚙️)]

I just need to update a test to account for some ID changes.

Comment 11

[Mike Conley (:mconley) (:⚙️)]

jya reviewed the patch, so clearing ni?.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dff00691b157
Add method for stopping visual cloning of a video, and a read-only property to check cloning state. r=jya,Ehsan
https://hg.mozilla.org/integration/autoland/rev/72e7ff2f9094
Fire UAWidget setup / change events when starting or stopping a visual clone of a <video> element. r=jya
https://hg.mozilla.org/integration/autoland/rev/54b6941ad622
Get rid of some dead CSS in videocontrols.css. r=jaws
https://hg.mozilla.org/integration/autoland/rev/7727f73edf0e
Update videocontrols error IDs to make it cleaner to introduce new message types. r=jaws
https://hg.mozilla.org/integration/autoland/rev/4854148dd534
Add strings, styles and mark-up for Picture-in-Picture message for a video with controls. r=jaws
https://hg.mozilla.org/integration/autoland/rev/9786398875b7
When the PictureInPicture window closes, stop cloning immediately to update the original video UAWidget. r=Felipe

Comment 13

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/dff00691b157
https://hg.mozilla.org/mozilla-central/rev/72e7ff2f9094
https://hg.mozilla.org/mozilla-central/rev/54b6941ad622
https://hg.mozilla.org/mozilla-central/rev/7727f73edf0e
https://hg.mozilla.org/mozilla-central/rev/4854148dd534
https://hg.mozilla.org/mozilla-central/rev/9786398875b7