Closed Bug 1531101 Opened 9 months ago Closed 8 months ago

Display a message about being in Picture-in-Picture mode in the original video

Categories

(Toolkit :: Video/Audio Controls, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(6 files)

When a video is put into Picture-in-Picture, we expect that the original <video> element should display a message saying that the <video> is in Picture-in-Picture.

Assignee: nobody → mconley

Hi jya - is ehsan's review sufficient for https://phabricator.services.mozilla.com/D22160?

Flags: needinfo?(jyavenard)
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/13a0c61ed4fc
Add method for stopping visual cloning of a video, and a read-only property to check cloning state. r=jya,Ehsan
https://hg.mozilla.org/integration/autoland/rev/5887b55233c2
Fire UAWidget setup / change events when starting or stopping a visual clone of a <video> element. r=jya
https://hg.mozilla.org/integration/autoland/rev/12bcda2d76db
Get rid of some dead CSS in videocontrols.css. r=jaws
https://hg.mozilla.org/integration/autoland/rev/4a4b44c3481a
Update videocontrols error IDs to make it cleaner to introduce new message types. r=jaws
https://hg.mozilla.org/integration/autoland/rev/44d96bcc51f7
Add strings, styles and mark-up for Picture-in-Picture message for a video with controls. r=jaws
https://hg.mozilla.org/integration/autoland/rev/10e9bbf2d1df
When the PictureInPicture window closes, stop cloning immediately to update the original video UAWidget. r=Felipe

I just need to update a test to account for some ID changes.

Flags: needinfo?(mconley)

jya reviewed the patch, so clearing ni?.

Flags: needinfo?(jyavenard)
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dff00691b157
Add method for stopping visual cloning of a video, and a read-only property to check cloning state. r=jya,Ehsan
https://hg.mozilla.org/integration/autoland/rev/72e7ff2f9094
Fire UAWidget setup / change events when starting or stopping a visual clone of a <video> element. r=jya
https://hg.mozilla.org/integration/autoland/rev/54b6941ad622
Get rid of some dead CSS in videocontrols.css. r=jaws
https://hg.mozilla.org/integration/autoland/rev/7727f73edf0e
Update videocontrols error IDs to make it cleaner to introduce new message types. r=jaws
https://hg.mozilla.org/integration/autoland/rev/4854148dd534
Add strings, styles and mark-up for Picture-in-Picture message for a video with controls. r=jaws
https://hg.mozilla.org/integration/autoland/rev/9786398875b7
When the PictureInPicture window closes, stop cloning immediately to update the original video UAWidget. r=Felipe
Depends on: 1534991
You need to log in before you can comment on or make changes to this bug.