1531120 - `arc patch` asks for password but it's not clear why

Status: RESOLVED WONTFIX

(Conduit :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Local cinnabar repo. I want to apply a patchset in phabricator locally to look at it, so I used arc patch and it asked for me a password out of the blue...

$ arc patch D20701
 INFO  Base commit is not in local repository; trying to fetch.
Password:

Comment 1

[:glob ✱]

can you please re-run the command with the --trace arg:

$ arc patch D20701 --trace

Comment 2

[Kartikaya Gupta (email:[e-mail])]

$ arc patch D20701 --trace
 ARGV  '/home/kats/zspace/arcanist/bin/../scripts/arcanist.php' 'patch' 'D20701' '--trace'
 LOAD  Loaded "phutil" from "/home/kats/zspace/libphutil/src".
 LOAD  Loaded "arcanist" from "/home/kats/zspace/arcanist/src".
Config: Reading user configuration file "/home/kats/.arcrc"...
Config: Did not find system configuration at "/etc/arcconfig".
Working Copy: Reading .arcconfig from "/home/kats/zspace/gecko-misc/.arcconfig".
Working Copy: Path "/home/kats/zspace/gecko-misc" is part of `git` working copy "/home/kats/zspace/gecko-misc".
Working Copy: Project root is at "/home/kats/zspace/gecko-misc".
Config: Did not find local configuration at "/home/kats/zspace/gecko-misc/.git/arc/config".
>>> [0] (+0) <http> https://phabricator.services.mozilla.com/api/differential.querydiffs
<<< [0] (+592) <http> 592,909 us
>>> [1] (+593) <http> https://phabricator.services.mozilla.com/api/user.whoami
<<< [1] (+731) <http> 138,678 us
>>> [2] (+732) <http> https://phabricator.services.mozilla.com/api/differential.querydiffs
<<< [2] (+3,877) <http> 3,144,809 us
>>> [3] (+3,922) <http> https://phabricator.services.mozilla.com/api/repository.query
<<< [3] (+4,084) <http> 162,204 us
>>> [4] (+4,086) <exec> $ git --version
<<< [4] (+4,090) <exec> 3,901 us
>>> [5] (+4,090) <exec> $ git status --porcelain=2 -z
<<< [5] (+4,977) <exec> 886,861 us
>>> [6] (+4,977) <exec> $ git cinnabar hg2git 'd99b59cc6347b5686aada8b02de75151bfe8f4dc'
<<< [6] (+5,139) <exec> 162,300 us
>>> [7] (+5,139) <exec> $ git show -s --format='%H' 'd99b59cc6347b5686aada8b02de75151bfe8f4dc' --
<<< [7] (+5,144) <exec> 4,259 us
 INFO  Base commit is not in local repository; trying to fetch.
>>> [8] (+5,144) <exec> $ git fetch --quiet --all
Password:

Comment 3

[:glob ✱]

looks like something with your git config is generating a password prompt (ssh cert auth maybe)?

if you run git fetch --all that should provide more context.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

One of my remotes is my laptop, and requires password auth for git fetch. Why is arc trying to do a git fetch --all? That seems undesirable in general. At most it should do something like git fetch hg::https://hg.mozilla.org/mozilla-unified for cinnabar repos.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

For now I've worked around this by adding skipDefaultUpdate=true to the relevant remotes in my gitconfig.

Comment 6

[:glob ✱]

we're in the process of removing our dependency on arc, and moz-phab has its own patch command which doesn't have this issue.