Figure out a way to import and run raw+negative hashbang test262 tests

RESOLVED FIXED in Firefox 67

Status

()

enhancement
RESOLVED FIXED
4 months ago
3 months ago

People

(Reporter: Waldo, Assigned: anba)

Tracking

Trunk
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(2 attachments)

Reporter

Description

4 months ago

Most of the hashbang test262 tests are "raw" tests -- that is, the script files are supposed to be run without alteration -- because it's crucial that "#!" (or an unreasonable facsimile of it being tested to not work) appear at the very start of the test. The raw hashbang tests that are expected to fail are no exception.

However, jstests as run in the shell encode "this test is expected to fail" using a

// |reftest| ...

comment at the start of the file -- conflicting with "#!" or an unreasonable facsimile of it.

We don't currently have a way to import raw-and-negative tests. We need one in order to run (and not skip) a fair number of the hashbang tests.

Assignee

Comment 1

4 months ago

The test record parser doesn't properly support all hashbang tests, I've filed https://github.com/tc39/test262/pull/2085 to fix it.

Assignee

Comment 3

4 months ago
  • Add separate function to import fixture files instead of treating them like
    test files. This simplifies the code structure a bit and avoids unnecessary
    output spew, because the test262 test record parser no longer complains about
    missing yaml frontmatter.
  • Write reftest terms into a new test262/jstests.list file for raw tests.
  • Allow including nested jstests.list files in _parse_external_manifest.
Assignee

Comment 4

4 months ago

Depends on D21677

Assignee

Updated

3 months ago
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED

Comment 6

3 months ago

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c450f92d5e62
Part 1: Don't prepend reftest entries in test262 'raw' tests. r=jwalden
https://hg.mozilla.org/integration/autoland/rev/84f0b9acc4e9
Part 2: Reimport test262. r=jwalden

Keywords: checkin-needed

Comment 7

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.