1531303 - Add a PermissionTestUtils module

Status: RESOLVED FIXED

(Core :: Permission Manager, enhancement, P3)

Description

[Johann Hofmann [:johannh]]

One major obstacle to dropping the nsIURI interfaces of nsIPermissionManager and SitePermissions.jsm is that a ton of tests are currently using URIs and it seems impractical to switch them all to build a principal every time (and also annoying to write new tests like this).

How about we make a PermissionTestUtils module that helps with this task by providing an interface that accepts an origin string or an nsIURI and automagically handles the conversion to principal and then calls Services.perms.addFromPrincipal etc.

Comment 1

[Emma Zühlcke [:emz]]

Attachment: Bug 1531303 - Refactored tests to use SitePermissions principal-based methods. r=johannh

Comment 2

[Emma Zühlcke [:emz]]

Attachment: Bug 1531303 - Implemented a PermissionTestUtils module. r=johannh

Comment 3

[Emma Zühlcke [:emz]]

Attachment: Bug 1531303 - Refactored tests using PermissionManager URI methods to use PermissionTestUtils. r=johannh

Depends on D41028

Comment 4

[Emma Zühlcke [:emz]]

Attachment: Bug 1531303 - Refactored tests using SitePermissions URI methods for PermissionTestUtils and principals. r=johannh

Depends on D41028

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/865c2a5d40da
Implemented a PermissionTestUtils module. r=johannh
https://hg.mozilla.org/integration/autoland/rev/0c75c3bac00b
Refactored tests using PermissionManager URI methods to use PermissionTestUtils. r=johannh

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87305e83174e
Refactored tests using SitePermissions URI methods for PermissionTestUtils and principals. r=johannh

Comment 7

[Andrei Ciure[:aciure]]

Backed out 3 changesets (bug 1531303) for causing close_window/close.py and browser_permissions_dialog.js to perma fail

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=0c75c3bac00be2683556c9dc5cde2e6426335c48

https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=87305e83174e205342c765ad4750e6e26879a3b8

failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=f70cd65cd5a913c34e1799c1b6fc931aefd7e6e3&selectedJob=261548340&searchStr=linux%2Cx64%2Cdebug%2Cweb%2Cplatform%2Ctests%2Ctest-linux64%2Fdebug-web-platform-tests-wdspec-e10s-1%2Cw%28wd1%29

https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=f70cd65cd5a913c34e1799c1b6fc931aefd7e6e3&selectedJob=261549573&searchStr=os%2Cx%2C10.14%2Cdebug%2Cmochitests%2Ctest-macosx1014-64%2Fdebug-mochitest-browser-chrome-e10s-6%2Cm%28bc6%29

backout: https://hg.mozilla.org/integration/autoland/rev/b03aef80e76a8feb6ab77cd89a6b8f901459e563

Comment 8

[Andrei Ciure[:aciure]]

The wd failures are not from this push:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=f70cd65cd5a913c34e1799c1b6fc931aefd7e6e3&selectedJob=261548340&searchStr=linux%2Cx64%2Cdebug%2Cweb%2Cplatform%2Ctests%2Ctest-linux64%2Fdebug-web-platform-tests-wdspec-e10s-1%2Cw%28wd1%29

so commit should be:
Backed out 3 changesets (bug 1531303) for causing browser_permissions_dialog.js to perma fail

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6b0f70a739a
Implemented a PermissionTestUtils module. r=johannh
https://hg.mozilla.org/integration/autoland/rev/31b2a7bf2932
Refactored tests using PermissionManager URI methods to use PermissionTestUtils. r=johannh
https://hg.mozilla.org/integration/autoland/rev/20ecb90e7155
Refactored tests using SitePermissions URI methods for PermissionTestUtils and principals. r=johannh

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e6b0f70a739a
https://hg.mozilla.org/mozilla-central/rev/31b2a7bf2932
https://hg.mozilla.org/mozilla-central/rev/20ecb90e7155

Comment 11

[(no longer active)]

Fantastic work, thanks a lot for doing this, Paul!