Closed
Bug 1531315
Opened 5 years ago
Closed 5 years ago
[remote-dbg-next] Prefix CSS classes used just for tests
Categories
(DevTools :: about:debugging, enhancement, P1)
DevTools
about:debugging
Tracking
(firefox68 fixed)
RESOLVED
FIXED
Firefox 68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: ogasidlo, Assigned: jdescottes)
References
(Blocks 1 open bug)
Details
(Whiteboard: [remote-debugging-reserve] remote-debugging-technical-debt)
Attachments
(1 file)
While investigating a failing test, I've realized we have removed a CSS class that we thought we do not need.
Another class is js-tmp-extension-install-error which has not landed yet, but will soon.
My suggestion would be to prefix css classes that are bound to a test.
|
Reporter | |
Comment 1•5 years ago
•
|
||
In the standup meeting, we decided to prefix those classes with qa-, so js-tmp-extension-install-error would change to qa-tmp-extension-install-error.
|
Assignee | |
Updated•5 years ago
|
Whiteboard: remote-debugging-technical-debt
|
|
Assignee | |
Comment 2•5 years ago
|
||
I don't think we have any patch that touches/adds such classes, let's do the renaming now.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
||
Updated•5 years ago
|
Priority: P3 → P1
Whiteboard: remote-debugging-technical-debt → [remote-debugging-reserve] remote-debugging-technical-debt
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3e3bc1430b82 Rename aboutdebugging test classnames from js-* to qa-* r=Ola
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in
before you can comment on or make changes to this bug.
Description
•