1531320 - docker-worker: `git pull` latest password store changes in deploy script

Status: RESOLVED WONTFIX

(Taskcluster :: Workers, enhancement)

Description

[Pete Moore [:pmoore][:pete]]

It would be easy to forget that the password store needs to be up-to-date when deploying docker-worker, so I added a git pull.

Note, this means you need to be on the vpn when doing a deployment, but I think this may be safer than not doing a git pull as this is an easy step to forget.

Comment 1

[Pete Moore [:pmoore][:pete]]

Attachment: GitHub Pull Request for docker-worker

Comment 2

[Wander Lairson Costa]

My experience is that docker-worker secrets rarely change, and having to 2FA everytime you need to run deploy.sh is counter-productive. Also, there is still the fact the other peer needs to remember to git push when keys are updated. Let's not add another human input to something it most probably won't be worth it. It is better to put this in the documentation.