Font Editor: Remove auto-increment behavior from range inputs

RESOLVED FIXED in Firefox 67

Status

enhancement
P3
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: rcaliman, Assigned: rcaliman)

Tracking

(Blocks 1 bug)

unspecified
Firefox 67
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

4 months ago

The feature isn't easily discoverable and when it does work, its user experience isn't good. We never invested time to refine it and we're unlikely to do so. At this point, this is dead code so we should remove it.

What is getting removed is the logic to support the esoteric auto-increment behavior which happens when dragging the range input thumb to the end of the slider and waiting for a while (1000ms). There's needless complexity in handling the concert of events for an experience with little value.

Users can still input out-of-range values in the text input field for the properties which allow it: font-size, line-height.

Assignee

Comment 1

4 months ago

With @mbalfanz's permission, I am removing the auto-increment behavior from the range inputs in the Font Editor.

The feature isn't easily discoverable and when it does work, its user experience isn't good. We never invested time to refine it and we're unlikely to do so. At this point, this is dead code so we should remove it.

What is getting removed is the logic to support the esoteric auto-increment behavior which happens when dragging the range input thumb to the end of the slider and waiting for a while (1000ms). There's needless complexity in handling the concert of events for a little perceived user value.

Users can still type out-of-range values in the text input field for the properties which allow it: font-size and line-height. For these properties' components, there's a new prop, allowOverflow, which permits values above the max defined. Other properties are bounded by min and max just like before.

Comment 2

4 months ago
Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6a9be28daf6e
Remove auto-increment from range inputs in Font Editor; r=gl

Comment 3

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.