1531356 - Decrease telemetry-tests-client CI max-run-time value

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P1)

Description

[Raphael Aurich [:raphael] UTC+02:00]

:aryx pointed out that telemetry-tests-client CI jobs typically complete in less than 10 minutes. That is why it is sensible to update the "max-run-time" setting, so that hanging test runs abort early rather than blocking for a long time.

Update "max-run-time" to "600".

https://searchfox.org/mozilla-central/source/taskcluster/ci/test/misc.yml#57

Comment 1

[Chris Hartjes [:grumpy][:chartjes]]

:raphael

Is there a way to verfiy that this change works when running them locally?

Comment 2

[Raphael Aurich [:raphael] UTC+02:00]

I don't think the setting has any effect on running tests locally.

You could however add a Python "time.sleep()" into any of the telemetry-tests-client tests with parameter longer than the new max-run-time and see what happens. Adding :aryx for ni on whether this is a good idea.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The time limits are not taken into account when run locally because the machine could be slower than CI. That the limit gets enforced is shown regularly in production (hangs, slow cloning etc.). No need to test in my opinion. If you want you can test it with Try.

Comment 4

[Chris Hartjes [:grumpy][:chartjes]]

Attachment: Bug 1531356 - Decrease telemetry-tests-client CI max-run-time value; r?raphael

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e57c2f2ddeff
Decrease telemetry-tests-client CI max-run-time value; r=raphael

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e57c2f2ddeff