Closed Bug 1531357 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 15509 - [LayoutNG] Fix 3 cases of break opportunities after nowrap

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 15509 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15509
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

[LayoutNG] Fix 3 cases of break opportunities after nowrap

This patch fixes lines to break in the following conditions:

  1. When wrappable elements appear inside of nowrap elements.
  2. When wrappable spaces after nowrap appear inside of nowrap
    elements.
  3. When non-space break opportunities appear after nowrap.

fast/text/whitespace/018.html improves but still doesn't pass.
It doesn't pass in Edge/Gecko, and at least some of what it
expects look questionable. Further investigation is deferred
to future CLs.

Bug: 920177
Change-Id: Ieba4d446b818120f423b87a7f4a44b3c63a9d995
Reviewed-on: https://chromium-review.googlesource.com/c/1477629
Commit-Queue: Koji Ishii \<kojii@chromium.org>
Reviewed-by: Xiaocheng Hu \<xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund \<eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#635180}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 1 tests
FAIL   : 1

New tests that have failures or other problems:
/css/css-text/white-space/white-space-wrap-after-nowrap-001.html: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f555f93c070
[wpt PR 15509] - [LayoutNG] Fix 3 cases of break opportunities after nowrap, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b01e9d570db
[wpt PR 15509] - Update wpt metadata, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/272d41054b82
[wpt PR 15509] - [LayoutNG] Fix 3 cases of break opportunities after nowrap, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/45cdd214896f
[wpt PR 15509] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/272d41054b82
https://hg.mozilla.org/mozilla-central/rev/45cdd214896f

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.