15314 - Descents cut off in URL field

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[buster]

in HTML text controls today, decending characters like lower case 'y' are cut
off at the text baseline.  I think the inner shell is getting sized incorrectly.

Comment 1

[cpratt]

buster is referring to serifs. i've seen this problem before; additionally, on
windows 9x, underscores are going missing (there is a bug filed against that
elsewhere).

Comment 2

[rods (gone)]

Attachment: Simple test of serif fonts

Comment 3

[rods (gone)]

Check out the attachment. This looks fine on NT, is this still a bug?

Comment 4

[rods (gone)]

Reassigning to editor, it could be their issue.

Comment 5

[rods (gone)]

This may be my issue after all

Comment 6

[rods (gone)]

The nsGFXTextControl is doing exactly what it should. The problem is the padding
is set incorrectly for all input[type=text] elements in the
skins.css. Here is the bad css:

window html|input[type=text] {
  border: 1px inset rgb(192, 192, 192);
  padding-top: 3px;
  padding-bottom: 2px;
  padding-left: 4px;
  padding-right: 3px;
  margin-top: 0px;
  margin-bottom: 2px;
  margin-left: 4px;
  margin-right: 3px;
  background-color: white;
  color: black;
  min-height: 1.75em;
}

Also, the padding is wrong for the textarea also.

Reassigning to browser group

Comment 7

[rods (gone)]

Sorry, this really did illustrate a problem with the GFX text I file a new bug
on the padding.

Comment 8

[rods (gone)]

fix is in my tree

Comment 9

[rods (gone)]

fixed

Comment 10

[Daniel Bratell]

*** Bug 14860 has been marked as a duplicate of this bug. ***

Comment 11

[Daniel Bratell]

A little thing. The part below the baseline is called "descent" and has nothing
to do with serifs which is something else. Serifs is the small extra curvy parts
on fonts as Times. Helvetica is an example of a non-serif font. I'm changing the
summary to reflect that and make this bug a little easier to find.

Comment 12

[rods (gone)]

Fixed

Comment 13

[cpratt]

And to think I had it wrong all these years... d'oh!! Nice to finally know what
a sans serif font is - thanks!

Underscores and descents are visible in the Location: control using the
1999100908 build under NT. Marking verified fixed.