Font Editor: fix issues raised by React in dev mode

RESOLVED FIXED in Firefox 67

Status

defect
P3
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: rcaliman, Assigned: rcaliman)

Tracking

(Blocks 1 bug)

unspecified
Firefox 67

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 months ago

There are historical issue in the Font Editor which stem from improper use of React and sloppy type coercion:

  • missing key properties in lists of rendered components
  • typos in element attributes as expected by React (ex: maxlength => maxLength)
  • incorrect type for axis & font property values as defined by component propTypes.

The React errors do not impact end users, but make for a noisy console. The inconsistent types for values create potential for new bugs.

The patch for this bugs corrects many of these issues.

(Assignee)

Comment 1

3 months ago
  • add key where necessary;
  • fix element attribute typos;
  • use consistent Number type for axis and font property values as defined by propTypes.

Comment 2

3 months ago
Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f5936ae0c1d6
Address errors shown by React in dev mode for Font Editor; r=gl

Comment 3

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.