1531449 - [wpt-sync] Sync PR 15579 - [webnfc] Rename NFCPushMessage union to NFCMessageSource.

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 15579 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15579
Details from upstream follow.

Rijubrata Bhaumik <[e-mail]> wrote:

[webnfc] Rename NFCPushMessage union to NFCMessageSource.

git grep -l 'NFCPushMessage' | xargs sed -i 's/NFCPushMessage/NDEFMessageSource/g'

Corresponding Spec changes:
https://github.com/w3c/web-nfc/commit/bf85df9e534da7351fc4c870228857dddef37e0e

Bug: 520391
Change-Id: I07980bfa1e68fc8959541442ddf4c83db968a52f
Reviewed-on: https://chromium-review.googlesource.com/c/1483028
Reviewed-by: Reilly Grant \<[e-mail]>
Reviewed-by: Philip Jägenstedt \<[e-mail]>
Commit-Queue: Rijubrata Bhaumik \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#636194}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ff41ac69ccf0a05fa5e69f9d6c3cb72dbfbff07

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=333104c43a62bb94418db81e96d09ead20829f15

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 1 tests and 12 subtests
OK     : 1
FAIL   : 12

New tests that have failures or other problems:
/web-nfc/nfc_push.https.html
    'Test that promise is rejected with SyntaxError if NFCMessage contains invalid records.: FAIL[linux32-debug,linux64-debug,linux64-opt]
    Reject promise with NotSupportedError if NFC message size exceeds 32KB.: FAIL[linux32-debug,linux64-debug,linux64-opt]
    Reject promise with SyntaxError if 'json' record cannot be serialized.: FAIL[linux32-debug,linux64-debug,linux64-opt]
    Reject promise with SyntaxError if WebNFC Id cannot be created from provided URL.: FAIL[linux32-debug,linux64-debug,linux64-opt]
    Test that WebNFC API is not accessible from iframe context.: FAIL[linux32-debug,linux64-debug,linux64-opt]
    Test that promise is rejected with TypeError if NFCMessage is invalid.: FAIL[linux32-debug,linux64-debug,linux64-opt]
    nfc.cancelPush should fail with TypeError when invalid id value is provided.: FAIL[linux32-debug,linux64-debug,linux64-opt]
    nfc.cancelPush should reject pending promise with AbortError.: FAIL[linux32-debug,linux64-debug,linux64-opt]
    nfc.push should fail with TimeoutError when timer expires.: FAIL[linux32-debug,linux64-debug,linux64-opt]
    nfc.push should fail with TypeError when invalid negative timeout value is provided.: FAIL[linux32-debug,linux64-debug,linux64-opt]
    nfc.push should fail with TypeError when invalid target value is provided.: FAIL[linux32-debug,linux64-debug,linux64-opt]
    nfc.push should fail with TypeError when invalid timeout is provided.: FAIL[linux32-debug,linux64-debug,linux64-opt]

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b4a3f5640122
[wpt PR 15579] - [webnfc] Rename NFCPushMessage union to NFCMessageSource., a=testonly

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b4a3f5640122