Open Bug 1531503 Opened 6 years ago Updated 1 year ago

crashtests that call open() on a window are bogus

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

Tracking Status
firefox67 --- affected

People

(Reporter: bzbarsky, Unassigned)

Details

Attachments

(1 obsolete file)

crashtests run with popup blocker enabled by default. But we have a number that call open() on window objects (https://searchfox.org/mozilla-central/search?q=open%28&path=crashtest is a superset and https://searchfox.org/mozilla-central/search?q=window.open%28&path=crashtest is a subset) and presumably aren't testing what they mean to test. We should audit them and see whether we can add the right pref() bits to turn off the popup blocker and maybe divert the loads to new windows instead of tabs as needed to make the tests work.

The relevant pref for this is "dom.disable_open_during_load". And maybe "browser.link.open_newwindow" should be set to "2".

Priority: -- → P3

We may want a higher priority here: this bug means that we are in fact missing test coverage that we think we have...

Flags: needinfo?(htsai)

Thanks for correcting and clarification, Boris. :)

Flags: needinfo?(htsai)
Priority: P3 → P2
Component: DOM → DOM: Core & HTML
Severity: normal → S3
Attachment #9387363 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: