1531592 - Repackage jobs not shown on treeherder since disabling opt

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Compare the number of tasks show on the first and last pushes here:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&searchStr=repackage&tochange=bf3951daded0b4fefd0fc81ee22ce5d536df2099&fromchange=57c4b2afc95bfb3c444c732802d99c8522414a1b

Regression range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=57c4b2afc95bfb3c444c732802d99c8522414a1b&tochange=bf3951daded0b4fefd0fc81ee22ce5d536df2099

It's pretty likely that bug 1522111 is the issue here. If you look at the task details for an example it has extra.treeherder.collection as {"opt/opt": true} instead of {"opt": true}.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Comparing
https://tools.taskcluster.net/groups/Re9PuFerQ7-guRrN86YAGQ/tasks/Zd-TWDBoTui_BsUYmtvATA/details
https://tools.taskcluster.net/groups/QZ988o8AQrq0ZJV8gbkbow/tasks/OH0MWbkCQeqGQ4K1CJ26lA/details
there's also a change from
"treeherder-platform": "linux32/opt"
to
"treeherder-platform": "linux32/opt/opt"

The collection appears to be keyed off this. The problem might lie at https://hg.mozilla.org/mozilla-central/file/98d4803bb2de/taskcluster/taskgraph/transforms/repackage.py#l226

Comment 2

[Justin Wood (:Callek)]

Confirmed with hg bisect and tom confirmed with code inspection:

The first bad revision is:
changeset: 526002:176bccfac2c7
user: Justin Wood <[e-mail]>
date: Mon Feb 18 17:55:38 2019 +0000
summary: Bug 1522111 - Make l10n kind depend on -pgo where available instead of opt. r=tomprince

https://hg.mozilla.org/mozilla-central/rev/176bccfac2c7#l6.14

Comment 3

[Tom Prince [:tomprince]]

Attachment: Bug 1531592: [taskgraph] Ensure that treeherder platform has the correct format; r?dustin

A recent change caused the treeherder platform for several jobs to have an extra / in it.
This add a check to ensure that the platform is formatted correctly, and fixes the tasks
with the incorrect format.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02dec1fe0aca
[taskgraph] Ensure that treeherder platform has the correct format; r=dustin

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/02dec1fe0aca