1531597 - Add an "action" API for the message display toolbar

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, enhancement)

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I have vague ideas, but what is this bug about?

Comment 2

[Geoff Lankow (:darktrojan)]

You're the one that wanted it. :-P

It's about adding button[s] to the message header so the user can do things with the displayed mail. I actually have half a patch somewhere if I ever dig my way out from under the large bugs I'm working on.

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: 1531597-message-display-action-1.diff

It turns out I did have half a patch, but the other half wasn't so easy.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9094105 [details] [diff] [review]
1531597-message-display-action-1.diff

Review of attachment 9094105 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/extensions/test/browser/browser_ext_messageDisplayAction.js
@@ +137,5 @@
> +  let messageWindowPromise = BrowserTestUtils.domWindowOpened();
> +  MsgOpenNewWindowForMessage();
> +  let messageWindow = await messageWindowPromise;
> +  await new Promise(resolve => messageWindow.setTimeout(resolve));
> +  await new Promise(resolve => messageWindow.setTimeout(resolve));

what's up with the double timeouts?

Comment 5

[plieser]

It would be nice if it would not just allow adding new buttons, but also extending the "More" button. Currently I don't add a separate button for my add-on, but just add a few entries to this button.

Comment 6

[Geoff Lankow (:darktrojan)]

(In reply to Magnus Melin [:mkmelin] from comment #4)

Comment on attachment 9094105 [details] [diff] [review]
what's up with the double timeouts?

I'm not sure, but it doesn't work otherwise. I assume there's something waiting to happen on the event loop, that causes something else to be added to the event loop.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0d126d5453bd
Add an API for the adding a button to the message display toolbar. r=mkmelin

Comment 8

[Geoff Lankow (:darktrojan)]

Comment on attachment 9094105 [details] [diff] [review]
1531597-message-display-action-1.diff

This slipped off my radar.

Comment 9

[Geoff Lankow (:darktrojan)]

Comment on attachment 9094105 [details] [diff] [review]
1531597-message-display-action-1.diff

Waaait a minute… this test doesn't pass on ESR.

Comment 10

[Geoff Lankow (:darktrojan)]

Attachment: 1531597-message-display-action-esr.diff

Comment 11

[Jorg K (CEST = GMT+2)]

TB 68.3 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/d401e2b789a4429cedc1b9549b252600b918932e