Closed Bug 1531597 Opened 1 year ago Closed 5 months ago

Add an "action" API for the message display toolbar

Categories

(Thunderbird :: Add-Ons: Extensions API, enhancement)

enhancement
Not set

Tracking

(thunderbird_esr6871+ fixed, thunderbird71 fixed)

RESOLVED FIXED
Thunderbird 71.0
Tracking Status
thunderbird_esr68 71+ fixed
thunderbird71 --- fixed

People

(Reporter: darktrojan, Assigned: darktrojan)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.
Depends on: 1575708

I have vague ideas, but what is this bug about?

Flags: needinfo?(geoff)

You're the one that wanted it. :-P

It's about adding button[s] to the message header so the user can do things with the displayed mail. I actually have half a patch somewhere if I ever dig my way out from under the large bugs I'm working on.

Flags: needinfo?(geoff)

It turns out I did have half a patch, but the other half wasn't so easy.

Assignee: nobody → geoff
Status: NEW → ASSIGNED
Attachment #9094105 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9094105 [details] [diff] [review]
1531597-message-display-action-1.diff

Review of attachment 9094105 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/extensions/test/browser/browser_ext_messageDisplayAction.js
@@ +137,5 @@
> +  let messageWindowPromise = BrowserTestUtils.domWindowOpened();
> +  MsgOpenNewWindowForMessage();
> +  let messageWindow = await messageWindowPromise;
> +  await new Promise(resolve => messageWindow.setTimeout(resolve));
> +  await new Promise(resolve => messageWindow.setTimeout(resolve));

what's up with the double timeouts?
Attachment #9094105 - Flags: review?(mkmelin+mozilla) → review+

It would be nice if it would not just allow adding new buttons, but also extending the "More" button. Currently I don't add a separate button for my add-on, but just add a few entries to this button.

(In reply to Magnus Melin [:mkmelin] from comment #4)

Comment on attachment 9094105 [details] [diff] [review]
what's up with the double timeouts?

I'm not sure, but it doesn't work otherwise. I assume there's something waiting to happen on the event loop, that causes something else to be added to the event loop.

Keywords: checkin-needed

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/0d126d5453bd
Add an API for the adding a button to the message display toolbar. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 71.0
Comment on attachment 9094105 [details] [diff] [review]
1531597-message-display-action-1.diff

This slipped off my radar.
Attachment #9094105 - Flags: approval-comm-esr68?
Comment on attachment 9094105 [details] [diff] [review]
1531597-message-display-action-1.diff

Waaait a minute… this test doesn't pass on ESR.
Attachment #9094105 - Flags: approval-comm-esr68?
Attachment #9108594 - Flags: review+
Attachment #9108594 - Flags: approval-comm-esr68?
Attachment #9108594 - Flags: approval-comm-esr68? → approval-comm-esr68+
You need to log in before you can comment on or make changes to this bug.