153164 - embed base library include in XPCOM_GLUE_LIBS

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Doug Turner (:dougt)]

This is wrong and needs to be fixed:

Index: configure.in
===================================================================
RCS file: /cvsroot/mozilla/configure.in,v
retrieving revision 1.1045
diff -u -r1.1045 configure.in
--- configure.in	11 Jun 2002 19:25:38 -0000	1.1045
+++ configure.in	20 Jun 2002 17:28:04 -0000
@@ -4299,9 +4299,9 @@
 dnl = Cleanup section for misc ordering snafus
 dnl =
 if test "$_WIN32_MSVC"; then
-    XPCOM_GLUE_LIBS='$(DIST)/lib/$(LIB_PREFIX)xpcomglue.$(LIB_SUFFIX)
$(DIST)/lib/$(LIB_PREFIX)string_s.$(LIB_SUFFIX)
$(DIST)/lib/$(LIB_PREFIX)string_obsolete_s.$(LIB_SUFFIX)
$(DIST)/lib/$(LIB_PREFIX)embed_base_s.$(LIB_SUFFIX)'
+    XPCOM_GLUE_LIBS='$(DIST)/lib/$(LIB_PREFIX)xpcomglue.$(LIB_SUFFIX)
$(DIST)/lib/$(LIB_PREFIX)string_s.$(LIB_SUFFIX)
$(DIST)/lib/$(LIB_PREFIX)string_obsolete_s.$(LIB_SUFFIX) 
 else
-    XPCOM_GLUE_LIBS='-L${DIST}/bin -L${DIST}/lib -lxpcomglue -lstring_s
-lstring_obsolete_s -lembed_base_s'
+    XPCOM_GLUE_LIBS='-L${DIST}/bin -L${DIST}/lib -lxpcomglue -lstring_s
-lstring_obsolete_s
 fi
 
 dnl ========================================================

Comment 1

[Doug Turner (:dougt)]

FIXED.

Comment 2

[John Morrison]

Doug. You lopped the closing ' off the end of the two lines that you changed.

Comment 3

[Doug Turner (:dougt)]

john, nice catch.  

Comment 4

[John Morrison]

Thanks. I was just seeing this odd "-L/lib not found" message when configure 
was running and I tracked it back to this change.

Comment 5

[Doug Turner (:dougt)]

fixed.