Closed
Bug 1531680
Opened 5 years ago
Closed 5 years ago
Don't disable LTO on standalone profile-generate builds
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox67 fixed)
RESOLVED
FIXED
mozilla67
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(1 file)
cf. discussion in https://phabricator.services.mozilla.com/D20695
Assignee | ||
Comment 1•5 years ago
|
||
On one-go MOZ_PGO builds, it's generally not wanted to do LTO during the
profile-generate phase. And the build system doesn't really support
different build options between both phases in this case, so we relied
on MOZ_PROFILE_GENERATE to disable the LTO flags.
However, in standalone profile-generate builds, if --enable-lto is
passed explicitly, the build should respect that choice.
So instead of checking MOZ_PROFILE_GENERATE to disable the LTO flags,
we disable them when MOZ_LTO is not set, and we force it to be disabled
during the profile-generate phase of one-go MOZ_PGO builds.
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/1bb2ca14033d Don't disable LTO on standalone profile-generate builds. r=chmanchester
Comment 3•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•