1531689 - Disable installing windows aarch64 builds on beta/release, until we are publishing builds on those channels.

Status: VERIFIED FIXED

(Firefox :: Installer, defect)

Description

[Tom Prince [:tomprince]]

We aren't currently publishing win64-aarch64 builds to archive.mozilla.org (and thus not on bouncer either).

It looks like the current stub installer will try to install them anyway. Should we have the stub installer fall back to the x86 release on those channels, for now?

Comment 2

[Molly Howell (she/her) (mostly inactive)]

We could do that; it would mean writing a small patch to have the stub only select ARM64 for the Nightly channel and then uplifting that patch to beta. Do you think that's how this should be handled?

Comment 3

[Chuck Harmston [:chuck]]

Of note, we're currently planning to publish and market win64-aarch64 beta builds shortly after the next release.

Comment 4

[Molly Howell (she/her) (mostly inactive)]

Oh, do you mean the next beta? In that case there's probably no need to bother with this, because it GTB's on Monday.

Comment 5

[Chuck Harmston [:chuck]]

That's the plan, though is of course subject to testing and our confidence in the build. I'll ultimately ask Ritu (already CCed here) to make that call.

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

(In reply to Matt Howell (he/him) [:mhowell] from comment #4)

Oh, do you mean the next beta? In that case there's probably no need to
bother with this, because it GTB's on Monday.

I think Chuck means after the next release/Merge when 67 goes to Beta. Currently, there are no plans to make arch64 beta66 builds available anywhere, not on Mozilla archives/balrog/bouncer.

Comment 7

[Molly Howell (she/her) (mostly inactive)]

Okay, so what we need is a patch that prevents the stub from from installing an aarch64 build on anything other than Nightly, but only for 66? Is that right?

Comment 8

[Molly Howell (she/her) (mostly inactive)]

Also, Ritu, what would you think about just landing this directly on mozilla-beta and bypassing m-c? The change is only needed for 66, and it would make for the simplest possible patch because I can make it unconditional, so it seems like that would make the most sense to me.

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

MHowell, TomPrince and I met and decided that it's a good idea to land this (one-line) fix in m-b directly since this fix should only prevent beta stub-installer versions from installing arm64 builds on arm64 CPUs and will instead install the emulated (x86 32-bit) Firefox beta build on ARM64 CPUs.

Nightly stub-installer will be unaffected by this change.

Liz, please let us know if you have any concerns with uplifting this fix. It should hopefully be a no-op for all other platform builds (except arm64) of 66 release.

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

It's worth dropping a note here that if we don't fix this, the stub-installer of beta builds fails to install any build on arm64 and doesn't leave the end-user with any guidance on how to fix this problem.

Comment 11

[Liz Henry (:lizzard)]

That sounds fine.

Comment 12

[Molly Howell (she/her) (mostly inactive)]

Attachment: Bug 1531689 - Prevent the stub from installing native AArch64 for version 66. r=agashlin

Comment 13

[Molly Howell (she/her) (mostly inactive)]

Comment on attachment 9048669 [details]
Bug 1531689 - Prevent the stub from installing native AArch64 for version 66. r=agashlin

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1512039
• User impact if declined: Stub installers for 66 on channels other than Nightly never succeed when run on AArch64 Windows computers.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1) Obtain a beta (or release) stub installer built with this patch.

2. Run the stub installer on an AArch64 Windows computer.
3. The installation should succeed and install a 32-bit x86 copy, not an AArch64 copy.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change is a stopgap that won't be applied past version 66 and only affects the stub installer on AArch64 systems (that is, the full installer isn't affected and no other architectures are affected).
• String changes made/needed:

Comment 14

[Liz Henry (:lizzard)]

Comment on attachment 9048669 [details]
Bug 1531689 - Prevent the stub from installing native AArch64 for version 66. r=agashlin

Fix for stub installer, let's land for beta 14.

Comment 15

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/releases/mozilla-beta/rev/051a0830599b

Comment 16

[Daniel Bodea [:danibodea]]

How do I obtain a Stub installer built with this patch?

Comment 17

[Molly Howell (she/her) (mostly inactive)]

There doesn't seem to have been one built for beta yet, but I found this one for dev edition, which is similar enough to beta to still be a valid test.

Comment 18

[Tom Prince [:tomprince]]

(In reply to Bodea Daniel [:danibodea] from comment #16)

How do I obtain a Stub installer built with this patch?

You can get them from https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&searchStr=win32%2Cnightly%2Csigning&job_type_symbol=ns&selectedJob=232400996 for now (until beta builds have been completed).

Once they are done, you can find the stub installer at https://archive.mozilla.org/pub/firefox/releases/66.0b14/win32/en-US/Firefox%20Installer.exe (for example)

Comment 19

[Daniel Bodea [:danibodea]]

I have verified this fix using a stub installer from here (https://archive.mozilla.org/pub/firefox/releases/66.0b14/win32/en-US/Firefox%20Installer.exe) on Lenovo Yoga C630. The installed build is target i686-pc-mingw32.

However, the Stub installer for Nightly, taken from here (http://archive.mozilla.org/pub/firefox/nightly/2019/03/2019-03-10-21-40-03-mozilla-central/Firefox%20Installer.en-US.exe) does install the Aarch64 build, unlike the Stub installer for Beta.

Considering all of the above are intended, I will mark this firefox66 as verified.
Please also mark the bug's status accordingly if needed.
Thank you.

Comment 20

[Molly Howell (she/her) (mostly inactive)]

(In reply to Bodea Daniel [:danibodea] from comment #19)

Considering all of the above are intended, I will mark this firefox66 as verified.
Please also mark the bug's status accordingly if needed.
Thank you.

Thanks!

I'm assuming this bug didn't get resolved because it didn't get the normal mozilla-central landing that would have triggered resolving it automatically, but everything is done here as far as I know so I'll resolve it now.

Comment 21

[Daniel Bodea [:danibodea]]

Yes, Matt. Wasn't sure whether it should be closed or not. Now fully verified, thank you.