1531690 - TypeError: can't redefine non-configurable property "BrowserUtils"

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Magnus Melin [:mkmelin]]

The TypeError: can't redefine non-configurable property "BrowserUtils" error has been showing up for some time, since bug 1520643 IIRC.

This is the bug to fix it. Going to take a look now.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1531690_BrowserUtils.patch

Once BrowserUtils was fixed, NetUtils was next causing trouble.

Since these are set up as lazy getters in toolkit/content/contentAreaUtils.js, our non-module js files can't declare them top level later on.

This patch is also cleaning up some unused imports

Comment 2

[Geoff Lankow (:darktrojan)]

Comment on attachment 9047650 [details] [diff] [review]
bug1531690_BrowserUtils.patch

Oh good, I was just about annoyed enough with this one to do something about it. Now I don't have to.

Comment 3

[Jorg K (CEST = GMT+2)]

I was annoyed, too ;-) Thanks.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 9047650 [details] [diff] [review]
bug1531690_BrowserUtils.patch

Review of attachment 9047650 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/prefs/content/converterDialog.js
@@ +14,2 @@
>  var {allAccountsSorted} = ChromeUtils.import("resource:///modules/folderUtils.jsm");
> +var MailstoreConverter = ChromeUtils.import("resource:///modules/mailstoreConverter.jsm");

Any particular reason for this change and its consequences?

Comment 5

[Magnus Melin [:mkmelin]]

That was just for sanity. The mailstoreConverter.jsm module exposes two functions. Previously those would get exposed as top level functions right there in the converterDialog.js, which makes it hard to understand where they are coming from. It's more understandable when you have to access convertMailStoreTo using MailstoreConverter.convertMailStoreTo - which is also the typical pattern for modules elsewhere

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/68560be6fb10
fix TypeError: can't redefine non-configurable property "BrowserUtils". r=darktrojan

Comment 7

[:aceman]

Interesting. But if it kills the error showing up just by starting TB, I'm happy :)