Don't double-clear Skia canvas2d

RESOLVED FIXED in Firefox 67

Status

()

enhancement
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: lsalzman, Assigned: lsalzman)

Tracking

({perf})

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Attachment #9047707 - Flags: review+
Comment on attachment 9047707 [details] [diff] [review]
don't clear Skia DTs backing Canvas2D if it is already clearing

Review of attachment 9047707 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/CanvasRenderingContext2D.cpp
@@ +233,5 @@
>    Point mEnd;
>  };
>  
>  bool CanvasRenderingContext2D::PatternIsOpaque(
> +    CanvasRenderingContext2D::Style aStyle, bool* aIsColor) const {

I suspect having a separate PatternIsColor function would be easier to read at a negligible cost.
Attachment #9047707 - Flags: review+
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5e9d61ee3f4
don't clear Skia DTs backing Canvas2D if it is already clearing. r=nical

Backed out changeset c5e9d61ee3f4 (bug 1531766) for bustage at CanvasRenderingContext2D.cpp on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/93ee0fb34c186f8b1f30a41a7f3deec499fa5dc8

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=c5e9d61ee3f40adb25a61d8cb571762eb2752606&selectedJob=231268093

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=231268093&repo=mozilla-inbound&lineNumber=32962

Log snippet:

[task 2019-03-01T15:58:05.147Z] 15:58:05 INFO - [style 0.0.1] cargo:rerun-if-changed=/builds/worker/workspace/build/src/obj-firefox/dist/include/nsUnicodeScriptCodes.h
[task 2019-03-01T15:58:05.149Z] 15:58:05 INFO - [style 0.0.1] cargo:rerun-if-changed=/builds/worker/workspace/build/src/obj-firefox/dist/include/nsContentCreatorFunctions.h
[task 2019-03-01T15:58:05.152Z] 15:58:05 INFO - Running /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name style servo/components/style/lib.rs --color never --crate-type lib --emit=dep-info,link -C opt-level=1 -C panic=abort -C debuginfo=2 -C debug-assertions=on --cfg 'feature="bindgen"' --cfg 'feature="fallible"' --cfg 'feature="gecko"' --cfg 'feature="gecko_debug"' --cfg 'feature="nsstring"' --cfg 'feature="regex"' --cfg 'feature="style_traits"' --cfg 'feature="toml"' --cfg 'feature="use_bindgen"' -C metadata=382588e7275e841c -C extra-filename=-382588e7275e841c --out-dir /builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps --target i686-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/debug/deps --extern app_units=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libapp_units-2c238c6791ff08f0.rlib --extern arrayvec=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libarrayvec-310962641e2c4c83.rlib --extern atomic_refcell=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libatomic_refcell-efb0cbcf1c6bad2a.rlib --extern bitflags=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libbitflags-47bea0f869b4cb49.rlib --extern byteorder=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libbyteorder-2bffbe732050e26b.rlib --extern cssparser=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libcssparser-023b0724999d9122.rlib --extern derive_more=/builds/worker/workspace/build/src/obj-firefox/debug/deps/libderive_more-560ba73643ef637c.so --extern euclid=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libeuclid-259d4256cdaf0833.rlib --extern fallible=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libfallible-24010bfc59c3e72c.rlib --extern fxhash=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libfxhash-5df2a3608fd21001.rlib --extern hashglobe=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libhashglobe-6ed51b07373fb36d.rlib --extern indexmap=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libindexmap-05d2fa7015494dfe.rlib --extern itertools=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libitertools-02a5f044f0cbb71e.rlib --extern itoa=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libitoa-992ff769baa36311.rlib --extern lazy_static=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/liblazy_static-2adca38c21f619e6.rlib --extern log=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/liblog-60a8c05956399c9e.rlib --extern malloc_size_of=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libmalloc_size_of-0f86f77dd8710366.rlib --extern malloc_size_of_derive=/builds/worker/workspace/build/src/obj-firefox/debug/deps/libmalloc_size_of_derive-be20d736ef5350ed.so --extern matches=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libmatches-a41490f5e1d18e77.rlib --extern debug_unreachable=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libdebug_unreachable-902269a202ce3813.rlib --extern nsstring=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libnsstring-e10d963824d62580.rlib --extern num_derive=/builds/worker/workspace/build/src/obj-firefox/debug/deps/libnum_derive-240a7ea4aa357f75.so --extern num_integer=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libnum_integer-c9ef12bc86879cfb.rlib --extern num_traits=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libnum_traits-99e2a909a498580b.rlib --extern num_cpus=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libnum_cpus-a5e27cc64a9ef194.rlib --extern ordered_float=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libordered_float-a400a412c43d68fb.rlib --extern owning_ref=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libowning_ref-8b72c715a849bed3.rlib --extern parking_lot=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libparking_lot-f56e13a4b426f560.rlib --extern precomputed_hash=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libprecomputed_hash-bb1e441dfc28ed27.rlib --extern rayon=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/librayon-232d1ae66440da4c.rlib --extern selectors=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libselectors-c2bf031a46b6101c.rlib --extern servo_arc=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libservo_arc-3bfe1a61c960e913.rlib --extern smallbitvec=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libsmallbitvec-c1474d0b09d56c34.rlib --extern smallvec=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libsmallvec-8ecebbaa9df5fc1e.rlib --extern style_derive=/builds/worker/workspace/build/src/obj-firefox/debug/deps/libstyle_derive-6f4ea746f60cc8cf.so --extern style_traits=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libstyle_traits-e53b7d159a88ab36.rlib --extern thin_slice=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libthin_slice-590aa2fdde1c9afa.rlib --extern time=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libtime-2f3c7e13882b15b3.rlib --extern uluru=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libuluru-916182866e5f682c.rlib --extern unicode_bidi=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libunicode_bidi-6b3e64c69657a4d3.rlib --extern unicode_segmentation=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libunicode_segmentation-e75cf1bc9329e0cf.rlib --extern void=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libvoid-8a76400d1e8ce2c1.rlib -C opt-level=2 -C debuginfo=2 -Dwarnings
[task 2019-03-01T15:58:05.152Z] 15:58:05 INFO - Compiling geckoservo v0.0.1 (/builds/worker/workspace/build/src/servo/ports/geckolib)
[task 2019-03-01T15:58:05.152Z] 15:58:05 INFO - Running /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name geckoservo servo/ports/geckolib/lib.rs --color never --crate-type lib --emit=dep-info,link -C opt-level=1 -C panic=abort -C debuginfo=2 -C debug-assertions=on --cfg 'feature="bindgen"' --cfg 'feature="gecko_debug"' --cfg 'feature="nsstring"' --cfg 'feature="style"' -C metadata=ef2fceb73af5dfcf -C extra-filename=-ef2fceb73af5dfcf --out-dir /builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps --target i686-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/debug/deps --extern atomic_refcell=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libatomic_refcell-efb0cbcf1c6bad2a.rlib --extern cssparser=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libcssparser-023b0724999d9122.rlib --extern cstr=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libcstr-72000060fadc379f.rlib --extern libc=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/liblibc-57b8c29f09b57047.rlib --extern log=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/liblog-60a8c05956399c9e.rlib --extern malloc_size_of=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libmalloc_size_of-0f86f77dd8710366.rlib --extern nsstring=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libnsstring-e10d963824d62580.rlib --extern num_traits=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libnum_traits-99e2a909a498580b.rlib --extern parking_lot=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libparking_lot-f56e13a4b426f560.rlib --extern selectors=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libselectors-c2bf031a46b6101c.rlib --extern servo_arc=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libservo_arc-3bfe1a61c960e913.rlib --extern smallvec=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libsmallvec-8ecebbaa9df5fc1e.rlib --extern style=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libstyle-382588e7275e841c.rlib --extern style_traits=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libstyle_traits-e53b7d159a88ab36.rlib -C opt-level=2 -C debuginfo=2 -Dwarnings
[task 2019-03-01T15:58:05.156Z] 15:58:05 INFO - Running /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name gkrust_shared toolkit/library/rust/shared/lib.rs --color never --crate-type lib --emit=dep-info,link -C opt-level=1 -C panic=abort -C debuginfo=2 -C debug-assertions=on --cfg 'feature="audioipc-client"' --cfg 'feature="audioipc-server"' --cfg 'feature="bindgen"' --cfg 'feature="cubeb-pulse"' --cfg 'feature="cubeb-remoting"' --cfg 'feature="cubeb-sys"' --cfg 'feature="cubeb_pulse_rust"' --cfg 'feature="default"' --cfg 'feature="encoding_c"' --cfg 'feature="encoding_glue"' --cfg 'feature="gecko_debug"' --cfg 'feature="gecko_profiler"' --cfg 'feature="geckoservo"' --cfg 'feature="jsrust_shared"' --cfg 'feature="moz_memory"' --cfg 'feature="mp4parse_capi"' --cfg 'feature="nsstring"' --cfg 'feature="profiler_helper"' --cfg 'feature="quantum_render"' --cfg 'feature="servo"' --cfg 'feature="simd-accel"' --cfg 'feature="spidermonkey_rust"' --cfg 'feature="webrender_bindings"' -C metadata=d44b017fb910cb22 -C extra-filename=-d44b017fb910cb22 --out-dir /builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps --target i686-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/debug/deps --extern arrayvec=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libarrayvec-310962641e2c4c83.rlib --extern audioipc_client=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libaudioipc_client-e51426444421e340.rlib --extern audioipc_server=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libaudioipc_server-23c436b69a52cbda.rlib --extern cosec=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libcosec-830e5eeb5ac74057.rlib --extern cubeb_pulse=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libcubeb_pulse-cde8d2da3f7261cd.rlib --extern cubeb_sys=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libcubeb_sys-a5a5038a293b262c.rlib --extern encoding_c=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libencoding_c-cdb00336f1820465.rlib --extern encoding_glue=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libencoding_glue-707d5b9dcfef2899.rlib --extern env_logger=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libenv_logger-7d63b4be9b3eeb12.rlib --extern geckoservo=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libgeckoservo-ef2fceb73af5dfcf.rlib --extern gkrust_utils=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libgkrust_utils-229386f48b323dc6.rlib --extern jsrust_shared=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libjsrust_shared-f20054b249201072.rlib --extern kvstore=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libkvstore-af7a57bf23c2fff5.rlib --extern log=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/liblog-60a8c05956399c9e.rlib --extern mozurl=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libmozurl-f67e87acbf2442ea.rlib --extern mp4parse_capi=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libmp4parse_capi-054d2d8306a4f495.rlib --extern netwerk_helper=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libnetwerk_helper-1ad3f11c704aae87.rlib --extern nserror=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libnserror-84043a5b4491fd76.rlib --extern nsstring=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libnsstring-e10d963824d62580.rlib --extern prefs_parser=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libprefs_parser-e78f99e3bbe5bafb.rlib --extern profiler_helper=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libprofiler_helper-a7016a45e7ac7382.rlib --extern rsdparsa_capi=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/librsdparsa_capi-9204e35402dd5ee5.rlib --extern u2fhid=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libu2fhid-4cd82f4cb055db94.rlib --extern webrender_bindings=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libwebrender_bindings-dc01a982c2ce9416.rlib --extern xpcom=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libxpcom-a27688c5b21e4cd4.rlib -C opt-level=2 -C debuginfo=2 -Dwarnings --cfg 'feature="oom_with_hook"' -L native=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/build/lmdb-rkv-sys-5adf33664f0da0c9/out
[task 2019-03-01T15:58:05.156Z] 15:58:05 INFO - Compiling gkrust v0.1.0 (/builds/worker/workspace/build/src/toolkit/library/rust)
[task 2019-03-01T15:58:05.156Z] 15:58:05 INFO - Running /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/rustc/bin/rustc --crate-name gkrust toolkit/library/rust/lib.rs --color never --crate-type staticlib --emit=dep-info,link -C opt-level=1 -C panic=abort -C debuginfo=2 -C debug-assertions=on --cfg 'feature="bindgen"' --cfg 'feature="cubeb-remoting"' --cfg 'feature="cubeb_pulse_rust"' --cfg 'feature="gecko_debug"' --cfg 'feature="gecko_profiler"' --cfg 'feature="gkrust-shared"' --cfg 'feature="moz_memory"' --cfg 'feature="quantum_render"' --cfg 'feature="servo"' --cfg 'feature="simd-accel"' --cfg 'feature="spidermonkey_rust"' -C metadata=3110fda9a4888fb3 -C extra-filename=-3110fda9a4888fb3 --out-dir /builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps --target i686-unknown-linux-gnu -C linker=/builds/worker/workspace/build/src/build/cargo-linker -L dependency=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps -L dependency=/builds/worker/workspace/build/src/obj-firefox/debug/deps --extern gkrust_shared=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libgkrust_shared-d44b017fb910cb22.rlib --extern mozilla_central_workspace_hack=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/deps/libmozilla_central_workspace_hack-409b3ee7c5ab80b6.rlib -C opt-level=2 -C debuginfo=2 -Dwarnings -L native=/builds/worker/workspace/build/src/obj-firefox/i686-unknown-linux-gnu/debug/build/lmdb-rkv-sys-5adf33664f0da0c9/out
[task 2019-03-01T15:58:05.156Z] 15:58:05 INFO - Finished dev [optimized + debuginfo] target(s) in 3m 11s
[task 2019-03-01T15:58:05.156Z] 15:58:05 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/library/rust'
[task 2019-03-01T15:58:05.615Z] 15:58:05 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/canvas'
[task 2019-03-01T15:58:05.615Z] 15:58:05 INFO - /builds/worker/workspace/build/src/sccache2/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -m32 -o Unified_cpp_dom_canvas0.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/dom/canvas -I/builds/worker/workspace/build/src/obj-firefox/dom/canvas -I/builds/worker/workspace/build/src/js/xpconnect/wrappers -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/dom/html -I/builds/worker/workspace/build/src/dom/svg -I/builds/worker/workspace/build/src/dom/workers -I/builds/worker/workspace/build/src/dom/xul -I/builds/worker/workspace/build/src/gfx/angle/checkout/include -I/builds/worker/workspace/build/src/gfx/gl -I/builds/worker/workspace/build/src/image -I/builds/worker/workspace/build/src/js/xpconnect/src -I/builds/worker/workspace/build/src/layout/generic -I/builds/worker/workspace/build/src/layout/style -I/builds/worker/workspace/build/src/layout/xul -I/builds/worker/workspace/build/src/media/libyuv/libyuv/include -I/builds/worker/workspace/build/src/gfx/skia -I/builds/worker/workspace/build/src/gfx/skia/skia/include/config -I/builds/worker/workspace/build/src/gfx/skia/skia/include/core -I/builds/worker/workspace/build/src/gfx/skia/skia/include/docs -I/builds/worker/workspace/build/src/gfx/skia/skia/include/gpu -I/builds/worker/workspace/build/src/gfx/skia/skia/include/utils -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fcrash-diagnostics-dir=/builds/worker/artifacts -march=pentium-m -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -Os -fno-omit-frame-pointer -funwind-tables -Werror -I/builds/worker/workspace/build/src/obj-firefox/dist/include/cairo -I/builds/worker/workspace/build/src/widget/gtk/compat-gtk3 -pthread -I/usr/include/gtk-3.0 -I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/gtk-3.0/unix-print -Wno-error=shadow -Wno-missing-braces -MD -MP -MF .deps/Unified_cpp_dom_canvas0.o.pp /builds/worker/workspace/build/src/obj-firefox/dom/canvas/Unified_cpp_dom_canvas0.cpp
[task 2019-03-01T15:58:05.615Z] 15:58:05 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/dom/canvas/Unified_cpp_dom_canvas0.cpp:20:
[task 2019-03-01T15:58:05.617Z] 15:58:05 ERROR - /builds/worker/workspace/build/src/dom/canvas/CanvasRenderingContext2D.cpp:2350:28: error: use of undeclared identifier 'RenderingMode'
[task 2019-03-01T15:58:05.617Z] 15:58:05 INFO - EnsureTarget(&clearRect, RenderingMode::DefaultBackendMode, true);
[task 2019-03-01T15:58:05.617Z] 15:58:05 INFO - ^
[task 2019-03-01T15:58:05.617Z] 15:58:05 ERROR - /builds/worker/workspace/build/src/dom/canvas/CanvasRenderingContext2D.cpp:2423:16: error: use of undeclared identifier 'RenderingMode'
[task 2019-03-01T15:58:05.617Z] 15:58:05 INFO - RenderingMode::DefaultBackendMode,
[task 2019-03-01T15:58:05.617Z] 15:58:05 INFO - ^
[task 2019-03-01T15:58:05.617Z] 15:58:05 INFO - 2 errors generated.
[task 2019-03-01T15:58:05.617Z] 15:58:05 INFO - /builds/worker/workspace/build/src/config/rules.mk:805: recipe for target 'Unified_cpp_dom_canvas0.o' failed
[task 2019-03-01T15:58:05.617Z] 15:58:05 ERROR - make[4]: *** [Unified_cpp_dom_canvas0.o] Error 1
[task 2019-03-01T15:58:05.618Z] 15:58:05 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/canvas'
[task 2019-03-01T15:58:05.618Z] 15:58:05 INFO - /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'dom/canvas/target' failed
[task 2019-03-01T15:58:05.618Z] 15:58:05 ERROR - make[3]: *** [dom/canvas/target] Error 2
[task 2019-03-01T15:58:05.618Z] 15:58:05 INFO - make[3]: *** Waiting for unfinished jobs....
[task 2019-03-01T15:58:09.149Z] 15:58:09 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/library/gtest/rust'
[task 2019-03-01T15:58:09.149Z] 15:58:09 INFO - toolkit/library/gtest/rust/force-cargo-library-build
[task 2019-03-01T15:58:09.149Z] 15:58:09 INFO - /builds/worker/workspace/build/src/rustc/bin/cargo rustc --frozen --manifest-path /builds/worker/workspace/build/src/toolkit/library/gtest/rust/Cargo.toml -vv --lib --target=i686-unknown-linux-gnu --features 'servo bindgen gecko_debug quantum_render cubeb_pulse_rust simd-accel cubeb-remoting moz_memory spidermonkey_rust gecko_profiler' --
[task 2019-03-01T15:58:09.149Z] 15:58:09 INFO - Blocking waiting for file lock on build directory
[task 2019-03-01T15:58:09.149Z] 15:58:09 INFO - Fresh unicode-xid v0.1.0
[task 2019-03-01T15:58:09.149Z] 15:58:09 INFO - Fresh libc v0.2.43
[task 2019-03-01T15:58:09.149Z] 15:58:09 INFO - Fresh nodrop v0.1.12

Flags: needinfo?(lsalzman)
Flags: needinfo?(lsalzman)
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fad9ff877c1c
don't clear Skia DTs backing Canvas2D if it is already clearing. r=nical
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.