Closed Bug 1531791 Opened 2 years ago Closed 2 years ago

Remove unused typedef StringToHistogramIdMap

Categories

(Toolkit :: Telemetry, enhancement, P3)

Product:
Toolkit
Component:
Telemetry
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox67 --- wontfix
firefox68 --- fixed

People

(Reporter: chutten, Assigned: arpitbharti73, Mentored)

Details

(Whiteboard: [good first bug][lang=c++])

Attachments

(1 file)

Bug 1531791 - Removed unused typedef StringToHistogramIdMap
47 bytes, text/x-phabricator-request
Details | Review

We define a type alias called StringToHistogramIdMap but never use it: https://searchfox.org/mozilla-central/search?q=StringToHistogramIdMap&redirect=false

We can remove it.

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
  2. Download and build the Firefox source code
    • If you have any problems, please ask on IRC in the #introduction channel. They're there to help you get started.
    • You can also read the Developer Guide, which has answers to most development questions:
  3. Start working on this bug. You will be editing toolkit/components/telemetry/core/TelemetryHistogram.cpp to remove the line with the StringToHistogramIdMap typedef.
    • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #telemetry channel on IRC most hours of most days.
  4. Build your change with mach build and test your change with mach test toolkit/components/telemetry/tests/. Also check your changes for adherence to our style guidelines by using mach lint
  5. Submit the patch for review. Mark me as a reviewer so I'll get an email to come look at your code.
  6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide!
  7. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.

Hi Chris, I'd be happy to help out with this bug! :)

(In reply to Chris H-C :chutten from comment #0)
I would like to contribute. Can you please assign it me?

We define a type alias called StringToHistogramIdMap but never use it: https://searchfox.org/mozilla-central/search?q=StringToHistogramIdMap&redirect=false

We can remove it.

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
  2. Download and build the Firefox source code
    • If you have any problems, please ask on IRC in the #introduction channel. They're there to help you get started.
    • You can also read the Developer Guide, which has answers to most development questions:
  3. Start working on this bug. You will be editing toolkit/components/telemetry/core/TelemetryHistogram.cpp to remove the line with the StringToHistogramIdMap typedef.
    • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #telemetry channel on IRC most hours of most days.
  4. Build your change with mach build and test your change with mach test toolkit/components/telemetry/tests/. Also check your changes for adherence to our style guidelines by using mach lint
  5. Submit the patch for review. Mark me as a reviewer so I'll get an email to come look at your code.
  6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide!
  7. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.

Assigning to :jjo. Let me know if you have any questions.

Assignee: nobody → jjo.su1822
Status: NEW → ASSIGNED

Hey Chris! Wanted to let you know that I fixed the bug, but I'm still getting familiar with the version control tools.

If I pushed a revision (that was accepted) before this bug, do you know how I might delete it from my "hg wip"? And is there a way I could update my files with the accepted patches so I could be up-to-date on what I'm working on? Thanks!

Hmm... Unfortunately I don't know hg well enough to help you here. (I use git to interact with the codebase, though an adaptor called git-cinnabar). You could try #introduction on IRC, or if you're familiar with Git then Mercurial has documentation to help you out.

(( I'm going to be away from work next week, so if you have any questions while I'm gone please use the "Need more information from" button and select "Mentor". I've temporarily drafted my teammate Alessio to help. ))

Mentor: chutten → alessio.placitelli

Unassigning due to inactivity.

Assignee: jjo.su1822 → nobody
Status: ASSIGNED → NEW

Can I be assigned to this?

This bug still exists?

Sorry for the delay. Alessio (the mentor) was and is away, but I've assigned it now.

Assignee: nobody → arpitbharti73
Status: NEW → ASSIGNED
Pushed by aplacitelli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/27557ba28e42
Removed unused typedef StringToHistogramIdMap r=Dexter

https://hg.mozilla.org/mozilla-central/rev/27557ba28e42

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.