1531806 - PgpMimeProxy: Pass URI to extensions

Status: RESOLVED FIXED

(MailNews Core :: MIME, enhancement)

Description

[Patrick Brunschwig]

We need a new solution to pass myUri to addons.

Comment 1

[Patrick Brunschwig]

Follow-up to 1531307

Comment 2

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/1025e23f16f7#l6.12
Can you pass the URI as the request?

Comment 3

[Patrick Brunschwig]

Yes, I'm think along that line. If we add "uri" to the interface in nsIPgpMimeProxy.idl, then we only need to change this:

nsCOMPtr<nsIURI> uri;
if (channel)
  channel->GetURI(getter_AddRefs(uri));

to:

nsCOMPtr<nsIURI> mUri;
if (channel)
  channel->GetURI(getter_AddRefs(mUri));

and we can remove myUri from SetMimeCallback.

Comment 4

[Patrick Brunschwig]

Attachment: Patch v1

The patch adds messageURI to nsIPgpMimeProxy. This way, the URI can be read via the nsIRequest object.

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 9047967 [details] [diff] [review]
Patch v1

Review of attachment 9047967 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good with the comment addressed. I haven't tested it, I guess it will do what you need.

::: mailnews/mime/cthandlers/pgpmime/nsPgpMimeProxy.cpp
@@ +298,5 @@
>  // nsPgpMimeProxy implementation
>  nsPgpMimeProxy::nsPgpMimeProxy()
>    : mInitialized(false),
>      mDecryptor(nullptr),
>      mLoadGroup(nullptr),

These two above are unnecessary and should be removed.

@@ +301,5 @@
>      mDecryptor(nullptr),
>      mLoadGroup(nullptr),
>      mLoadFlags(LOAD_NORMAL),
> +    mCancelStatus(NS_OK),
> +    mMessageURI(nullptr)

The constructor or nsCOMPtr already nulls the pointer, so you can remove this.

Comment 6

[Patrick Brunschwig]

Attachment: patch v1.1

Thanks here is the updated patch. I tried it successfully with an adopted version of Enigmail.

Can you commit it?

Comment 7

[Jorg K (CEST = GMT+2)]

Sure.

Comment 8

[Jorg K (CEST = GMT+2)]

Comment on attachment 9048021 [details] [diff] [review]
patch v1.1

Thanks.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f58cbe43514a
Add nsIPgpMimeProxy.messageURI. r=jorgk