1531831 - Several deep links are broken

Status: VERIFIED FIXED

(Firefox for iOS :: General, enhancement, P1)

Description

[Justin D'Arcangelo [:justindarc]]

The following deep links are no longer working:

firefox://deep-link?url=settings/newtab
firefox://deep-link?url=settings/homepage
firefox://deep-link?url=homepanel/new-private-tab
firefox://deep-link?url=settings/general

Comment 1

[Justin D'Arcangelo [:justindarc]]

JSBin page for testing deep links:

https://output.jsbin.com/zeyezuf

Comment 2

[Simon Basca [:SimonB]]

The following links are still broken. Tapping on them in Safari just opens Firefox and does not go to the correct screen. For the first link I would expect to be directed to the Reading List and for the second one I would expect for a New Private Tab to open.

firefox://deep-link?url=homepanel/reading-list
firefox://deep-link?url=homepanel/new-private-tab

Also I am not seeing any difference when opening the following links:

firefox://fxa-signin?service=asdf&context=123&signin=test&entrypoint=one&utm_source=somesource&ignore=this
firefox://fxa-signin?signin=test&utm_source=somesource&entrypoint=one&ignore=this

They both open the sign in to FxA dialog.

Justin can you please have a look?

Comment 3

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/43a4fcaf779b8caadb3f2b4cc898588967555090

Comment 4

[Simon Basca [:SimonB]]

Verifying as fix on 15.1(14275).