1531860 - Chat messages not showing

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Patrick Cloke [:clokep]]

Chat messages are not appearing in today's daily. The input box, participants list, etc. all seems to work fine, but the browser showing the incoming/outgoing messages is just a white box.

Doesn't seem to be anything in the error console, I do see the following in the logs:

JavaScript error: resource://gre/modules/XPCOMUtils.jsm, line 316: TypeError: can't redefine non-configurable property "BrowserUtils"
JavaScript error: chrome://messenger/content/msgViewPickerOverlay.js, line 95: TypeError: gFolderDisplay is null
<at this point I shutdown Thunderbird>
console.warn: "Error while detaching the browsing context target front: undefined"

Comment 1

[Magnus Melin [:mkmelin]]

Looking at treeheader builds:
0022c92d1421 - broken Thu, Feb 28, 19:58:01
d7609d079bc3 - ok - Thu, Feb 28, 11:07:01

Perhaps something from mozilla central then? I think:
https://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2019-02-28+09%3A07%3A01&enddate=2019-02-28+19%3A58%3A01

Comment 2

[Magnus Melin [:mkmelin]]

From either bug 1531128 or bug 1489308, verified by backing them out locally.

We're not moving on like we used to in onStateChange: https://searchfox.org/comm-central/source/chat/content/conversation-browser.js#43

Comment 3

[Kai Engert (:KaiE:)]

(In reply to Magnus Melin [:mkmelin] from comment #2)

From either bug 1531128 or bug 1489308, verified by backing them out locally.

I tried to backout all 11 patches from both bugs (2+9), and now I get build errors.

Comment 4

[Kai Engert (:KaiE:)]

Ignore comment 3, looks like I had missed something. Tried again, and I confirm backing out both bugs makes it work again.

Comment 5

[Florian Quèze [:florian]]

Attachment: Bug 1531860 - Finish initializing the chat browser when receiving STATE_STOP and STATE_IS_WINDOW, as calling document.open no longer causes notifications at the document level, r=clokep.

Comment 6

[Florian Quèze [:florian]]

This is caused by changes from bug 1489308. We call document.open at https://searchfox.org/comm-central/rev/8a64171478a67b80775e23c37992cdf1dbd99e54/chat/modules/imThemes.jsm#630 and that used to result in state progress notifications with the STATE_IS_DOCUMENT flag; this is no longer the case.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5861d9446cd7
Finish initializing the chat browser when receiving STATE_STOP and STATE_IS_WINDOW, as calling document.open no longer causes notifications at the document level, r=clokep.

Comment 8

[Magnus Melin [:mkmelin]]

\o/

We really need to get some UI tests going for chat.

Comment 9

[Florian Quèze [:florian]]

We definitely need more test coverage, yes. But we also need sheriffing practices to change so that when a test does catch bustage we don't disable the test as a "bustage fix" (see bug 1528574 comment 4 and later).

Comment 10

[Magnus Melin [:mkmelin]]

Filed bug 1533689 for tests.

Re disabling tests: it's not optimal to disable real failures, but I think the current situation is slightly misunderstood. Yes, we disable perma-fails even though real (they usually are) - but only to be able to notice new failures. The important thing to note is that they are still tracked, just not through treeherder.

One possibly way to improve that would be to add perma-fail support to treeherder through some marking.

Comment 11

[Patrick Cloke [:clokep]]

(In reply to Magnus Melin [:mkmelin] from comment #10)

Re disabling tests: it's not optimal to disable real failures, but I think the current situation is slightly misunderstood. Yes, we disable perma-fails even though real (they usually are) - but only to be able to notice new failures. The important thing to note is that they are still tracked, just not through treeherder.

Where are they tracked?

Comment 12

[Magnus Melin [:mkmelin]]

In bugzilla, whitboard: [Thunderbird-disabled-test]