WR refactor internation types

RESOLVED FIXED in Firefox 67

Status

()

enhancement
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: kvark, Assigned: kvark)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

I find the current system of types related to internation to be quite difficult to navigate. There are generic structures like DataStore, Interner, and there are a few traits, like Internable and AsInstanceKind.

However, we also have a module called intern_types, which tries to bind all the associated types together, independently of the Internable. Some of the internable types don't implement the trait. There is quite a bit of redundancy and noisy generic syntax involved, that could be better.

Assignee: nobody → dmalyshau
Status: NEW → ASSIGNED

Remove the intern_types module in favor of the associated Internable types that we already have.
The only bit of magic I had to do is around serialization bounds, and it's nicely isolated.

That one extra space...
Re-landing now

Flags: needinfo?(dmalyshau)
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.