Change all 'RemoteLogins:*' message names to 'PasswordManager:*' in pwmgr code

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P3
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: prathiksha, Assigned: E_Carr, Mentored)

Tracking

({good-first-bug})

unspecified
mozilla67
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox67 fixed)

Details

(Whiteboard: [passwords:tech-debt] [lang=js], URL)

Attachments

(1 attachment)

(Reporter)

Description

3 months ago

Change the message name prefixes from 'RemoteLogins'[0] to 'PasswordManager' for better understanding.

[0] https://searchfox.org/mozilla-central/rev/00f3836a87b844b5e4bc82f698c559b9966e4be2/browser/components/BrowserGlue.jsm#533

Here are search results for all matches: https://searchfox.org/mozilla-central/search?q=RemoteLogins%3A&case=false&regexp=false&path=

Once a review is submitted I will assign the bug.

Mentor: MattN+bmo
Severity: normal → enhancement
Flags: qe-verify-
Keywords: good-first-bug
OS: Unspecified → All
Priority: -- → P3
Hardware: Unspecified → All
Whiteboard: [passwords:tech-debt] [lang=js]
(Assignee)

Comment 2

3 months ago

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)

Here are search results for all matches: https://searchfox.org/mozilla-central/search?q=RemoteLogins%3A&case=false&regexp=false&path=

Once a review is submitted I will assign the bug.

Hello Matthew, my name is Erik and I am an Outreachy candidate. I would like the opportunity to contribute by taking on this bug, can I please be assigned to it. I'd appreciate it very much, thanks.

(In reply to Erik Carrillo [:E_Carr] from comment #2)

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)

Here are search results for all matches: https://searchfox.org/mozilla-central/search?q=RemoteLogins%3A&case=false&regexp=false&path=

Once a review is submitted I will assign the bug.

Hello Matthew, my name is Erik and I am an Outreachy candidate. I would like the opportunity to contribute by taking on this bug, can I please be assigned to it. I'd appreciate it very much, thanks.

Hello, feel free to start. As I said in comment 1, …

Once a review is submitted I will assign the bug.

(Assignee)

Comment 4

3 months ago

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #3)

(In reply to Erik Carrillo [:E_Carr] from comment #2)

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)

Here are search results for all matches: https://searchfox.org/mozilla-central/search?q=RemoteLogins%3A&case=false&regexp=false&path=

Once a review is submitted I will assign the bug.

Hello Matthew, my name is Erik and I am an Outreachy candidate. I would like the opportunity to contribute by taking on this bug, can I please be assigned to it. I'd appreciate it very much, thanks.

Hello, feel free to start. As I said in comment 1, …

Once a review is submitted I will assign the bug.

I'll start on it right away and if I have questions I'll be sure to reach out. Thanks again.

(Assignee)

Comment 5

3 months ago

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)

Here are search results for all matches: https://searchfox.org/mozilla-central/search?q=RemoteLogins%3A&case=false&regexp=false&path=

Once a review is submitted I will assign the bug.

Just to verify I understand this correctly, I have to find all the occurrences of RemoteLogins and replace them with PasswordManager in the files returned from the searchfox results, correct?

Yes, replace "RemoteLogins:" (usually with the colon) with "PasswordManager:"

(Assignee)

Comment 7

3 months ago

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #6)

Yes, replace "RemoteLogins:" (usually with the colon) with "PasswordManager:"

Am I suppose to also do it on the Test Files as well? If so that's all I would need to complete this task, otherwise I am finished.

yes, everywhere, including tests and comments.

Assignee: nobody → ecarr3344
Status: NEW → ASSIGNED
(Assignee)

Comment 10

3 months ago

Matthew, I can't thank you enough for all your help. As a new comer to the FOSS community, things can be a bit overwhelming at first, but people like you make this exciting transition much easier.

Glad to hear that :) I queued your change to be checked-in when the repository re-opens within the next few hours.

Comment 12

3 months ago
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/e2b8ea7e00d9
Change all RemoteLogins message names to PasswordManager in pwmgr code. r=MattN

Comment 13

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.