Change all 'RemoteLogins:*' message names to 'PasswordManager:*' in pwmgr code
Categories
(Toolkit :: Password Manager, enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: prathiksha, Assigned: E_Carr, Mentored)
References
()
Details
(Keywords: good-first-bug, Whiteboard: [passwords:tech-debt] [lang=js])
Attachments
(1 file)
Change the message name prefixes from 'RemoteLogins'[0] to 'PasswordManager' for better understanding.
Comment 1•5 years ago
|
||
Here are search results for all matches: https://searchfox.org/mozilla-central/search?q=RemoteLogins%3A&case=false®exp=false&path=
Once a review is submitted I will assign the bug.
Assignee | ||
Comment 2•5 years ago
|
||
(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)
Here are search results for all matches: https://searchfox.org/mozilla-central/search?q=RemoteLogins%3A&case=false®exp=false&path=
Once a review is submitted I will assign the bug.
Hello Matthew, my name is Erik and I am an Outreachy candidate. I would like the opportunity to contribute by taking on this bug, can I please be assigned to it. I'd appreciate it very much, thanks.
Comment 3•5 years ago
|
||
(In reply to Erik Carrillo [:E_Carr] from comment #2)
(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)
Here are search results for all matches: https://searchfox.org/mozilla-central/search?q=RemoteLogins%3A&case=false®exp=false&path=
Once a review is submitted I will assign the bug.
Hello Matthew, my name is Erik and I am an Outreachy candidate. I would like the opportunity to contribute by taking on this bug, can I please be assigned to it. I'd appreciate it very much, thanks.
Hello, feel free to start. As I said in comment 1, …
Once a review is submitted I will assign the bug.
Assignee | ||
Comment 4•5 years ago
|
||
(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #3)
(In reply to Erik Carrillo [:E_Carr] from comment #2)
(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)
Here are search results for all matches: https://searchfox.org/mozilla-central/search?q=RemoteLogins%3A&case=false®exp=false&path=
Once a review is submitted I will assign the bug.
Hello Matthew, my name is Erik and I am an Outreachy candidate. I would like the opportunity to contribute by taking on this bug, can I please be assigned to it. I'd appreciate it very much, thanks.
Hello, feel free to start. As I said in comment 1, …
Once a review is submitted I will assign the bug.
I'll start on it right away and if I have questions I'll be sure to reach out. Thanks again.
Assignee | ||
Comment 5•5 years ago
|
||
(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)
Here are search results for all matches: https://searchfox.org/mozilla-central/search?q=RemoteLogins%3A&case=false®exp=false&path=
Once a review is submitted I will assign the bug.
Just to verify I understand this correctly, I have to find all the occurrences of RemoteLogins
and replace them with PasswordManager
in the files returned from the searchfox results, correct?
Comment 6•5 years ago
|
||
Yes, replace "RemoteLogins:" (usually with the colon) with "PasswordManager:"
Assignee | ||
Comment 7•5 years ago
|
||
(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #6)
Yes, replace "RemoteLogins:" (usually with the colon) with "PasswordManager:"
Am I suppose to also do it on the Test Files as well? If so that's all I would need to complete this task, otherwise I am finished.
Comment 8•5 years ago
|
||
yes, everywhere, including tests and comments.
Updated•5 years ago
|
Assignee | ||
Comment 9•5 years ago
|
||
Assignee | ||
Comment 10•5 years ago
|
||
Matthew, I can't thank you enough for all your help. As a new comer to the FOSS community, things can be a bit overwhelming at first, but people like you make this exciting transition much easier.
Comment 11•5 years ago
|
||
Glad to hear that :) I queued your change to be checked-in when the repository re-opens within the next few hours.
Comment 12•5 years ago
|
||
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/e2b8ea7e00d9 Change all RemoteLogins message names to PasswordManager in pwmgr code. r=MattN
Comment 13•5 years ago
|
||
bugherder |
Description
•