1531959 - Change all 'RemoteLogins:*' message names to 'PasswordManager:*' in pwmgr code

Status: RESOLVED FIXED

(Toolkit :: Password Manager, enhancement, P3)

Description

[:prathiksha]

Change the message name prefixes from 'RemoteLogins'[0] to 'PasswordManager' for better understanding.

[0] https://searchfox.org/mozilla-central/rev/00f3836a87b844b5e4bc82f698c559b9966e4be2/browser/components/BrowserGlue.jsm#533

Comment 1

[Matthew N. [:MattN]]

Here are search results for all matches: https://searchfox.org/mozilla-central/search?q=RemoteLogins%3A&case=false&regexp=false&path=

Once a review is submitted I will assign the bug.

Comment 2

[Erik Carrillo [:E_Carr]]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)

Here are search results for all matches: https://searchfox.org/mozilla-central/search?q=RemoteLogins%3A&case=false&regexp=false&path=

Once a review is submitted I will assign the bug.

Hello Matthew, my name is Erik and I am an Outreachy candidate. I would like the opportunity to contribute by taking on this bug, can I please be assigned to it. I'd appreciate it very much, thanks.

Comment 3

[Matthew N. [:MattN]]

(In reply to Erik Carrillo [:E_Carr] from comment #2)

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)

Here are search results for all matches: https://searchfox.org/mozilla-central/search?q=RemoteLogins%3A&case=false&regexp=false&path=

Once a review is submitted I will assign the bug.

Hello Matthew, my name is Erik and I am an Outreachy candidate. I would like the opportunity to contribute by taking on this bug, can I please be assigned to it. I'd appreciate it very much, thanks.

Hello, feel free to start. As I said in comment 1, …

Once a review is submitted I will assign the bug.

Comment 4

[Erik Carrillo [:E_Carr]]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #3)

(In reply to Erik Carrillo [:E_Carr] from comment #2)

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)

Here are search results for all matches: https://searchfox.org/mozilla-central/search?q=RemoteLogins%3A&case=false&regexp=false&path=

Once a review is submitted I will assign the bug.

Hello Matthew, my name is Erik and I am an Outreachy candidate. I would like the opportunity to contribute by taking on this bug, can I please be assigned to it. I'd appreciate it very much, thanks.

Hello, feel free to start. As I said in comment 1, …

Once a review is submitted I will assign the bug.

I'll start on it right away and if I have questions I'll be sure to reach out. Thanks again.

Comment 5

[Erik Carrillo [:E_Carr]]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)

Here are search results for all matches: https://searchfox.org/mozilla-central/search?q=RemoteLogins%3A&case=false&regexp=false&path=

Once a review is submitted I will assign the bug.

Just to verify I understand this correctly, I have to find all the occurrences of RemoteLogins and replace them with PasswordManager in the files returned from the searchfox results, correct?

Comment 6

[Matthew N. [:MattN]]

Yes, replace "RemoteLogins:" (usually with the colon) with "PasswordManager:"

Comment 7

[Erik Carrillo [:E_Carr]]

(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #6)

Yes, replace "RemoteLogins:" (usually with the colon) with "PasswordManager:"

Am I suppose to also do it on the Test Files as well? If so that's all I would need to complete this task, otherwise I am finished.

Comment 8

[Matthew N. [:MattN]]

yes, everywhere, including tests and comments.

Comment 9

[Erik Carrillo [:E_Carr]]

Attachment: Bug 1531959 - Change all RemoteLogins message names to PasswordManager in pwmgr code. r=MattN

Comment 10

[Erik Carrillo [:E_Carr]]

Matthew, I can't thank you enough for all your help. As a new comer to the FOSS community, things can be a bit overwhelming at first, but people like you make this exciting transition much easier.

Comment 11

[Matthew N. [:MattN]]

Glad to hear that :) I queued your change to be checked-in when the repository re-opens within the next few hours.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2b8ea7e00d9
Change all RemoteLogins message names to PasswordManager in pwmgr code. r=MattN

Comment 13

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/e2b8ea7e00d9