Closed Bug 1532034 Opened 4 years ago Closed 4 years ago

browser_privateBrowsingWindowChange.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/browser.xul]

Categories

(Firefox :: Address Bar, defect, P2)

Product:
Firefox
Component:
Address Bar
Type:
defect
Points:
5

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 68
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 --- unaffected
firefox68 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: mak)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

Bug 1532034 - leak in browser_privateBrowsingWindowChange.js. r=Standard8
47 bytes, text/x-phabricator-request
Details | Review

#[markdown(off)]
Filed by: apavel [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=231431466&repo=autoland

https://queue.taskcluster.net/v1/task/IEX-O7tKQm6onh1HbgKryg/runs/0/artifacts/public/logs/live_backing.log

[task 2019-03-02T09:30:01.449Z] 09:30:01 INFO - TEST-START | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js
[task 2019-03-02T09:30:01.598Z] 09:30:01 INFO - GECKO(1067) | ++DOCSHELL 0x7f833901d800 == 24 [pid = 1067] [id = {6c29619f-3ac6-42ca-9afa-d288f802f217}]
[task 2019-03-02T09:30:01.600Z] 09:30:01 INFO - GECKO(1067) | ++DOMWINDOW == 49 (0x7f8339068c00) [pid = 1067] [serial = 49] [outer = (nil)]

[task 2019-03-02T09:30:22.403Z] 09:30:22 INFO - TEST-INFO | Main app process: exit 0
[task 2019-03-02T09:30:22.411Z] 09:30:22 ERROR - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/browser.xul]
[task 2019-03-02T09:30:22.412Z] 09:30:22 ERROR - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | leaked 1 window(s) until shutdown [url = about:blank]
[task 2019-03-02T09:30:22.413Z] 09:30:22 INFO - TEST-INFO | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | windows(s) leaked: [pid = 1067] [serial = 17], [pid = 1067] [serial = 18]
[task 2019-03-02T09:30:22.414Z] 09:30:22 ERROR - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | leaked 1 docShell(s) until shutdown
[task 2019-03-02T09:30:22.415Z] 09:30:22 INFO - TEST-INFO | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | docShell(s) leaked: [pid = 1067] [id = {aa0d2f2f-f8cf-4b60-a286-f17ac3890a62}]
[task 2019-03-02T09:30:22.416Z] 09:30:22 INFO - TEST-INFO | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | This test created 1 hidden window(s)
[task 2019-03-02T09:30:22.417Z] 09:30:22 INFO - TEST-INFO | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | This test created 1 hidden docshell(s)
[task 2019-03-02T09:30:22.418Z] 09:30:22 ERROR - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/browser.xul]
[task 2019-03-02T09:30:22.419Z] 09:30:22 ERROR - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | leaked 1 window(s) until shutdown [url = about:blank]
[task 2019-03-02T09:30:22.420Z] 09:30:22 INFO - TEST-INFO | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | windows(s) leaked: [pid = 1067] [serial = 21], [pid = 1067] [serial = 22]
[task 2019-03-02T09:30:22.421Z] 09:30:22 ERROR - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | leaked 1 docShell(s) until shutdown
[task 2019-03-02T09:30:22.431Z] 09:30:22 INFO - TEST-INFO | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | docShell(s) leaked: [pid = 1067] [id = {a41ce244-2661-478b-a0b6-b8d7a30bab11}]
[task 2019-03-02T09:30:22.432Z] 09:30:22 INFO - TEST-INFO | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | This test created 1 hidden window(s)
[task 2019-03-02T09:30:22.433Z] 09:30:22 INFO - TEST-INFO | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | This test created 1 hidden docshell(s)
[task 2019-03-02T09:30:22.434Z] 09:30:22 ERROR - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/browser.xul]
[task 2019-03-02T09:30:22.435Z] 09:30:22 ERROR - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | leaked 1 window(s) until shutdown [url = about:blank]
[task 2019-03-02T09:30:22.436Z] 09:30:22 INFO - TEST-INFO | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | windows(s) leaked: [pid = 1067] [serial = 25], [pid = 1067] [serial = 26]
[task 2019-03-02T09:30:22.437Z] 09:30:22 ERROR - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | leaked 1 docShell(s) until shutdown
[task 2019-03-02T09:30:22.438Z] 09:30:22 INFO - TEST-INFO | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | docShell(s) leaked: [pid = 1067] [id = {72fac539-3054-4810-9657-faee3c7f1ed0}]
[task 2019-03-02T09:30:22.439Z] 09:30:22 INFO - TEST-INFO | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | This test created 1 hidden window(s)
[task 2019-03-02T09:30:22.439Z] 09:30:22 INFO - TEST-INFO | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | This test created 1 hidden docshell(s)
[task 2019-03-02T09:30:22.440Z] 09:30:22 ERROR - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | leaked 1 window(s) until shutdown [url = about:blank]
[task 2019-03-02T09:30:22.441Z] 09:30:22 ERROR - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/browser.xul]
[task 2019-03-02T09:30:22.442Z] 09:30:22 INFO - TEST-INFO | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | windows(s) leaked: [pid = 1067] [serial = 30], [pid = 1067] [serial = 29]
[task 2019-03-02T09:30:22.443Z] 09:30:22 ERROR - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | leaked 1 docShell(s) until shutdown
[task 2019-03-02T09:30:22.444Z] 09:30:22 INFO - TEST-INFO | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | docShell(s) leaked: [pid = 1067] [id = {bb94d1e0-43f2-4d2a-b399-b7e8df5e037a}]
[task 2019-03-02T09:30:22.446Z] 09:30:22 INFO - TEST-INFO | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | This test created 1 hidden window(s)
[task 2019-03-02T09:30:22.447Z] 09:30:22 INFO - TEST-INFO | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | This test created 1 hidden docshell(s)
[task 2019-03-02T09:30:22.448Z] 09:30:22 ERROR - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/browser.xul]
[task 2019-03-02T09:30:22.449Z] 09:30:22 ERROR - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | leaked 1 window(s) until shutdown [url = about:blank]
[task 2019-03-02T09:30:22.450Z] 09:30:22 INFO - TEST-INFO | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | windows(s) leaked: [pid = 1067] [serial = 49], [pid = 1067] [serial = 50]
[task 2019-03-02T09:30:22.451Z] 09:30:22 ERROR - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | leaked 1 docShell(s) until shutdown
[task 2019-03-02T09:30:22.452Z] 09:30:22 INFO - TEST-INFO | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | docShell(s) leaked: [pid = 1067] [id = {6c29619f-3ac6-42ca-9afa-d288f802f217}]
[task 2019-03-02T09:30:22.453Z] 09:30:22 INFO - TEST-INFO | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | This test created 1 hidden window(s)
[task 2019-03-02T09:30:22.454Z] 09:30:22 INFO - TEST-INFO | browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | This test created 1 hidden docshell(s)

https://hg.mozilla.org/integration/autoland/rev/9ee8480e23e7cb86d5cb934e2259c26c31130679

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID

I'm going to be re-landing this, but with the test disabled for debug, so re-opening to handle the fix for it.

Blocks: quantumbar-release, quantumbar-tests
Status: RESOLVED → REOPENED
Keywords: intermittent-failure
Priority: P5 → P2
Resolution: INVALID → ---
Summary: Intermittent browser/components/urlbar/tests/browser/browser_privateBrowsingWindowChange.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/browser.xul] → browser_privateBrowsingWindowChange.js | leaked 1 window(s) until shutdown [url = chrome://browser/content/browser.xul]
Whiteboard: [fxsearch]
Depends on: 1531347

Bug 1521755 notes this was happening intermittently on test-verify previously.

I'll try Marco's suggestion.

Assignee: nobody → standard8
See Also: → 1521755

(In reply to Marco Bonardo [::mak] from comment #4)

You may try doing this https://searchfox.org/mozilla-central/rev/92d11a33250a8e368c8ca3e962e15ca67117f765/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_placestitle.js#62

Unfortunately that doesn't seem to work. I've also tried a couple of other things:

  1. Replacing continuePromise and the onLocationChange listener with BrowserTestUtils.waitForNewWindow({url: "about:privatebrowsing"});
  2. Adding an extra promise to wait for browser-delayed-startup-finished

What did seem to work after 1 was to add a one-second delay before finishing the test. This would be before closing the window as well. This makes me wonder if there's something else we should be waiting for on a new window.

Just to note, I can reproduce this on a --verify run locally with an artifact debug build.

I'm not sure where to go with this one at the moment.

Assignee: standard8 → nobody
No longer blocks: quantumbar-release
Points: --- → 5
Assignee: nobody → mak77
Status: REOPENED → ASSIGNED
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/afab3cd818fb
leak in browser_privateBrowsingWindowChange.js. r=Standard8

https://hg.mozilla.org/mozilla-central/rev/afab3cd818fb

Status: ASSIGNED → RESOLVED
Closed: 4 years ago → 4 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Keywords: regression
You need to log in before you can comment on or make changes to this bug.