1532096 - [i3] picture in picture wrong _NET_WM_WINDOW_TYPE on Xorg/Linux

Status: RESOLVED DUPLICATE of bug 1553835

(Toolkit :: Video/Audio Controls, defect, P3)

Description

[Danny Colin [:sdk]]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

1. Double-click right button mouse on a video
2. Choose Picture in Picture

Actual results:

Picture in picture open as a tiled window in bspwm or i3 (they're both Tiling Window Manager on Linux) because _NET_WM_WINDOW_TYPE is set to NORMAL

Expected results:

_NET_WM_WINDOW_TYPE should be set to DIALOG so the Window Manager knows it needs to open it as a floating window.

Comment 1

[:Gijs (he/him)]

Ni Mike to prio this.

Comment 2

[Tom S [:evilpie]]

I think changing PLAYER_FEATURES to include dialog (source) would fix this. It's quite likely however that changing the window type would cause other issues.

Comment 3

[Danny Colin [:sdk]]

(In reply to Tom Schuster [:evilpie] from comment #2)

I think changing PLAYER_FEATURES to include dialog (source) would fix this. It's quite likely however that changing the window type would cause other issues.

I think you could also change the state of the window to make sure the Window Manager float the window by default https://specifications.freedesktop.org/wm-spec/1.3/ar01s05.html

Comment 4

[Tom S [:evilpie]]

Did bug 1543027 fix this?

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Dialog should not be used on Linux - see Bug 1580733. We can craft the toplevel window to be on/top and floating by other way.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

I guess _NET_WM_WINDOW_TYPE_DOCK or _NET_WM_WINDOW_TYPE_UTILITY is more suitable for the PIP window. Frankly I don't know how are those handled by i3.

Can you try to set a different _NET_WM_WINDOW_TYPE for the PIP window under i3 and see if that works for you? see
https://stackoverflow.com/questions/19035043/setting-x11-type-property-for-xmessage

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Also PIP sets WM_NAME/WM_CLASS to Toolkit / PictureInPicture.

We can also set special WM_ROLE for that window to allow i3 to handle it specially. But this is more i3 window integrating bug than a general Firefox bug.

Also, can you please check how Chromium PIP window is handled on i3?

Thanks.

Comment 8

[Danny Colin [:sdk]]

Can you try to set a different _NET_WM_WINDOW_TYPE for the PIP window under i3 and see if that works for you? see
https://stackoverflow.com/questions/19035043/setting-x11-type-property-for-xmessage

Doesn't seem to work. Also I use bspwm not i3. I also switched to Fedora on the laptop where I had that issue (It was running Debian 10). I don't know if something change recently in Nightly but it seems like on Fedora with the same bspwm version the PIP opens correctly as a floating window in the bottom right corner.

However, there still is one little problem. A small portion (~3px) of the right and bottom part of the PIP window is off-screen.

Comment 9

[Dennis van der Schagt [:dennisschagt]]

Can you try to set a different _NET_WM_WINDOW_TYPE for the PIP window under i3 and see if that works for you? see
https://stackoverflow.com/questions/19035043/setting-x11-type-property-for-xmessage

Doesn't seem to work.

It looks like i3 only looks at the _NET_WM_WINDOW_TYPE property once at time of window creation.
Changing the window type using xprop didn't work for me either.
However, changing it before window creation did result in a floating window.

This is implemented as a fix for bug 1553835.

A small portion (~3px) of the right and bottom part of the PIP window is off-screen.

I expect this is due to window borders (PIP window currently has titlebar/borders on i3).

Comment 10

[Danny Colin [:sdk]]

(In reply to Dennis van der Schagt [:dennisschagt] from comment #9)

A small portion (~3px) of the right and bottom part of the PIP window is off-screen.

I expect this is due to window borders (PIP window currently has titlebar/borders on i3).

It doesn't have a border on bspwm where this issue happens. I've opened 1587869.