Closed
Bug 1532109
Opened 5 years ago
Closed 5 years ago
composition contacts sidebar does not display until all contacts are loaded
Categories
(Thunderbird :: Message Compose Window, enhancement)
Thunderbird
Message Compose Window
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 68.0
People
(Reporter: aceman, Assigned: aceman)
Details
Attachments
(2 files)
|
1.30 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
|
1.13 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
In Thunderbird's compose window, if you open the Contacts sidebar (F9), it shows all contact cards from the last used addressbook. That may take a while if you have thousands of cards. Until all are fetched the sidebar contents are not drawn and the space is empty.
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Attachment #9059661 -
Flags: review?(mkmelin+mozilla)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9059661 [details] [diff] [review] 1532109.patch Review of attachment 9059661 [details] [diff] [review]: ----------------------------------------------------------------- LGTM thx, r=mkmelin
Attachment #9059661 -
Flags: review?(mkmelin+mozilla) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/8d373d4dbcb6
show contacts sidebar before searching contacts for the matching AB. r=mkmelin
|
||
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 68.0
Sadly this broke the test test-send-button.js::test_send_enabled_address_contacts_sidebar on all debug platforms.
This should fix it.
Attachment #9061153 -
Flags: review?(jorgk)
|
|
||
Comment 6•5 years ago
|
||
Comment on attachment 9061153 [details] [diff] [review] 1532109-2.patch Thanks. Sadly especially Linux64 debug still looks like a mine field :-(
Attachment #9061153 -
Flags: review?(jorgk) → review+
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/2ff21f9b6206 Follow-up: fix test of contact sidebar results. r=jorgk DONTBUILD
You need to log in
before you can comment on or make changes to this bug.
Description
•