Closed Bug 1532171 Opened 9 months ago Closed 9 months ago

Light text on dark background is displayed incorrectly in 67.0a1

Categories

(Core :: Graphics, defect, P1)

67 Branch
Desktop
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox-esr60 --- unaffected
firefox65 --- unaffected
firefox66 --- fixed
firefox67 --- fixed

People

(Reporter: nunya.b.zwax, Assigned: lsalzman)

References

Details

(Keywords: regression)

Attachments

(2 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

This issue appeared spontaneously in nightly builds of 67.0a1 with no change in settings between updates.

Actual results:

Light text on dark backgrounds appears with a white border.

Expected results:

Text should not be displayed with this border.

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0
20190303215808

Looks OK on Windows. It would be very useful if you could find the regression range.
https://mozilla.github.io/mozregression/quickstart.html

Status: UNCONFIRMED → NEW
Has Regression Range: --- → no
Component: Untriaged → Graphics: Text
Ever confirmed: true
Flags: needinfo?(nunya.b.zwax)
Flags: needinfo?(jesterking)
OS: Unspecified → macOS
Product: Firefox → Core
Hardware: Unspecified → Desktop
Duplicate of this bug: 1532210

Are you using some add-ons or do you have any prefs changed in about:config. Also, could you try reproducing the issue on a clean profile, and if you're still seeing the issue, please paste the about:support section in the bug.

(In reply to Gingerbread Man from comment #1)

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0
20190303215808

Looks OK on Windows. It would be very useful if you could find the regression range.
https://mozilla.github.io/mozregression/quickstart.html

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2e63fa41257b8950f5726fd88936ba3f5e2d8441&tochange=571c5aa0458018f62d1f0832fc0e92fa3f23fda9

Flags: needinfo?(nunya.b.zwax)

FYI, as written in 1532210 there are some cases where disabling CSS color on an element forces better drawing. This issue happens on clean profile as well.

Note that this draw error is most apparent with Mojave Dark Mode, but it happens also with Light Mode.

Application Basics
------------------

Name: Firefox
Version: 67.0a1
Build ID: 20190303215808
Update Channel: nightly
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:67.0) Gecko/20100101 Firefox/67.0
OS: Darwin 18.2.0
Multiprocess Windows: 1/1 Enabled by default
Web Content Processes: 8/8
Enterprise Policies: Inactive
Google Key: Found
Mozilla Location Service Key: Found
Safe Mode: false

Crash Reports
-------------

All Crash Reports    Nightly Features
-------------------------------------

Name: Firefox Monitor
Version: 3.0
ID: fxmonitor@mozilla.org

Name: Firefox Screenshots
Version: 37.1.0
ID: screenshots@mozilla.org

Name: Form Autofill
Version: 1.0
ID: formautofill@mozilla.org

Name: Web Compat
Version: 4.0.0
ID: webcompat@mozilla.org

Name: WebCompat Reporter
Version: 1.1.0
ID: webcompat-reporter@mozilla.org

Extensions
----------

Name: Adblock Plus - free ad blocker
Version: 3.4.3
Enabled: true
ID: {d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}

Name: DuckDuckGo Privacy Essentials
Version: 2019.1.31
Enabled: true
ID: jid1-ZAdIEUB7XOzOJw@jetpack

Name: FoxyProxy Standard
Version: 6.3
Enabled: true
ID: foxyproxy@eric.h.jung

Name: NoScript
Version: 10.2.1
Enabled: true
ID: {73a6fe31-595d-460b-a920-fcc0f8843232}

Name: Tridactyl
Version: 1.14.8pre2424
Enabled: true
ID: tridactyl.vim.betas@cmcaine.co.uk

Name: uBlock Origin
Version: 1.18.4
Enabled: true
ID: uBlock0@raymondhill.net

Name: Video DownloadHelper
Version: 7.3.5
Enabled: true
ID: {b9db16a4-6edc-47ec-a1f4-b86292ed211d}

Name: AdBlock
Version: 3.26.0
Enabled: false
ID: jid1-NIfFY2CA8fy1tg@jetpack

Name: Blur
Version: 7.8.2431
Enabled: false
ID: donottrackplus@abine.com

Name: Firebug
Version: 2.0.19
Enabled: false
ID: firebug@software.joehewitt.com

Name: Tamper Data
Version: 11.0.1.1-signed.1-signed
Enabled: false
ID: {9c51bd27-6ed8-4000-a2bf-36cb95c0c947}

Name: Vimperator
Version: 3.16.0
Enabled: false
ID: vimperator@mozdev.org

Security Software
----------------- Type:

Type:

Type:

Graphics
--------

Features
Compositing: OpenGL
asyncPanZoom: wheel input enabled; scrollbar drag enabled; keyboard enabled; autoscroll enabled
webgl1WSIInfo: CGL
WebGL 1 Driver Renderer: Intel Inc. -- Intel(R) Iris(TM) Graphics 650
WebGL 1 Driver Version: 4.1 INTEL-12.4.7
WebGL 1 Driver Extensions: GL_ARB_blend_func_extended GL_ARB_draw_buffers_blend GL_ARB_draw_indirect GL_ARB_ES2_compatibility GL_ARB_explicit_attrib_location GL_ARB_gpu_shader_fp64 GL_ARB_gpu_shader5 GL_ARB_instanced_arrays GL_ARB_internalformat_query GL_ARB_occlusion_query2 GL_ARB_sample_shading GL_ARB_sampler_objects GL_ARB_separate_shader_objects GL_ARB_shader_bit_encoding GL_ARB_shader_subroutine GL_ARB_shading_language_include GL_ARB_tessellation_shader GL_ARB_texture_buffer_object_rgb32 GL_ARB_texture_cube_map_array GL_ARB_texture_gather GL_ARB_texture_query_lod GL_ARB_texture_rgb10_a2ui GL_ARB_texture_storage GL_ARB_texture_swizzle GL_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback3 GL_ARB_vertex_attrib_64bit GL_ARB_vertex_type_2_10_10_10_rev GL_ARB_viewport_array GL_EXT_debug_label GL_EXT_debug_marker GL_EXT_framebuffer_multisample_blit_scaled GL_EXT_texture_compression_s3tc GL_EXT_texture_filter_anisotropic GL_EXT_texture_sRGB_decode GL_APPLE_client_storage GL_APPLE_container_object_shareable GL_APPLE_flush_render GL_APPLE_object_purgeable GL_APPLE_rgb_422 GL_APPLE_row_bytes GL_APPLE_texture_range GL_ATI_texture_mirror_once GL_NV_texture_barrier
WebGL 1 Extensions: ANGLE_instanced_arrays EXT_blend_minmax EXT_color_buffer_half_float EXT_disjoint_timer_query EXT_frag_depth EXT_shader_texture_lod EXT_sRGB EXT_texture_compression_rgtc EXT_texture_filter_anisotropic OES_element_index_uint OES_standard_derivatives OES_texture_float OES_texture_float_linear OES_texture_half_float OES_texture_half_float_linear OES_vertex_array_object WEBGL_color_buffer_float WEBGL_compressed_texture_s3tc WEBGL_compressed_texture_s3tc_srgb WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_depth_texture WEBGL_draw_buffers WEBGL_lose_context
WebGL 2 Driver WSI Info: CGL
WebGL 2 Driver Renderer: Intel Inc. -- Intel(R) Iris(TM) Graphics 650
WebGL 2 Driver Version: 4.1 INTEL-12.4.7
WebGL 2 Driver Extensions: GL_ARB_blend_func_extended GL_ARB_draw_buffers_blend GL_ARB_draw_indirect GL_ARB_ES2_compatibility GL_ARB_explicit_attrib_location GL_ARB_gpu_shader_fp64 GL_ARB_gpu_shader5 GL_ARB_instanced_arrays GL_ARB_internalformat_query GL_ARB_occlusion_query2 GL_ARB_sample_shading GL_ARB_sampler_objects GL_ARB_separate_shader_objects GL_ARB_shader_bit_encoding GL_ARB_shader_subroutine GL_ARB_shading_language_include GL_ARB_tessellation_shader GL_ARB_texture_buffer_object_rgb32 GL_ARB_texture_cube_map_array GL_ARB_texture_gather GL_ARB_texture_query_lod GL_ARB_texture_rgb10_a2ui GL_ARB_texture_storage GL_ARB_texture_swizzle GL_ARB_timer_query GL_ARB_transform_feedback2 GL_ARB_transform_feedback3 GL_ARB_vertex_attrib_64bit GL_ARB_vertex_type_2_10_10_10_rev GL_ARB_viewport_array GL_EXT_debug_label GL_EXT_debug_marker GL_EXT_framebuffer_multisample_blit_scaled GL_EXT_texture_compression_s3tc GL_EXT_texture_filter_anisotropic GL_EXT_texture_sRGB_decode GL_APPLE_client_storage GL_APPLE_container_object_shareable GL_APPLE_flush_render GL_APPLE_object_purgeable GL_APPLE_rgb_422 GL_APPLE_row_bytes GL_APPLE_texture_range GL_ATI_texture_mirror_once GL_NV_texture_barrier
WebGL 2 Extensions: EXT_color_buffer_float EXT_disjoint_timer_query EXT_texture_compression_rgtc EXT_texture_filter_anisotropic OES_texture_float_linear WEBGL_compressed_texture_s3tc WEBGL_compressed_texture_s3tc_srgb WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_lose_context
Uses Tiling: true
Uses Tiling (Content): true
Off Main Thread Painting Enabled: true
Off Main Thread Painting Worker Count: 3
Target Frame Rate: 60
GPU #1
Active: Yes
Vendor ID: 0x8086
Device ID: 0x5927

Diagnostics
AzureCanvasBackend: skia
AzureContentBackend: skia
AzureFallbackCanvasBackend: none
TileHeight: 1024
TileWidth: 1024
Decision Log
WEBRENDER:
opt-in by default: WebRender is an opt-in feature
WEBRENDER_QUALIFIED:
blocked by env: No qualified hardware




Media
-----

Audio Backend: audiounit
Max Channels: 2
Preferred Sample Rate: 44100
Output Devices
Name: Group
Sisäiset kaiuttimet: AppleHDAEngineOutput:1F,3,0,1,1:0
Input Devices
Name: Group
Sisäinen mikrofoni: AppleHDAEngineInput:1F,3,0,1,0:1

Important Modified Preferences
------------------------------

accessibility.typeaheadfind.flashBar: 0
browser.cache.disk.capacity: 1048576
browser.cache.disk.filesystem_reported: 1
browser.cache.disk.hashstats_reported: 1
browser.cache.disk.smart_size.first_run: false
browser.cache.frecency_experiment: 4
browser.display.background_color: #d4d3d5
browser.download.useDownloadDir: false
browser.places.smartBookmarksVersion: 8
browser.sessionstore.upgradeBackup.latestBuildID: 20190303215808
browser.startup.homepage_override.buildID: 20190303215808
browser.startup.homepage_override.mstone: 67.0a1
browser.tabs.warnOnClose: false
browser.urlbar.matchBuckets: general:5,suggestion:Infinity
browser.urlbar.maxRichResults: 12
browser.urlbar.placeholderName: DuckDuckGo
browser.urlbar.timesBeforeHidingSuggestionsHint: 0
dom.forms.autocomplete.formautofill: true
dom.push.userAgentID: e3832de37c0646d2bad894312607c1b5
extensions.formautofill.firstTimeUse: false
extensions.lastAppVersion: 67.0a1
font.internaluseonly.changed: true
font.name.sans-serif.x-western: Courier New
font.name.serif.x-western: Courier New
general.autoScroll: false
general.useragent.locale: en
idle.lastDailyNotification: 1551641607
media.benchmark.vp9.fps: 103
media.benchmark.vp9.versioncheck: 5
media.gmp-gmpopenh264.abi: x86_64-gcc3
media.gmp-gmpopenh264.lastUpdate: 1526828309
media.gmp-gmpopenh264.version: 1.7.1
media.gmp-manager.buildID: 20190303215808
media.gmp-manager.lastCheck: 1551679247
media.gmp-widevinecdm.abi: x86_64-gcc3
media.gmp-widevinecdm.lastUpdate: 1542202078
media.gmp-widevinecdm.version: 4.10.1196.0
media.gmp.storage.version.observed: 1
network.cookie.prefsMigrated: true
network.dns.disablePrefetch: true
network.http.speculative-parallel-limit: 0
network.predictor.cleaned-up: true
network.predictor.enabled: false
network.prefetch-next: false
network.trr.experimentalRollout: -2
places.database.lastMaintenance: 1551381792
places.history.expiration.transient_current_max_pages: 154506
plugin.disable_full_page_plugin_for_types: application/pdf
print.print_bgcolor: false
print.print_bgimages: false
print.print_duplex: 0
print.print_evenpages: true
print.print_in_color: true
print.print_margin_bottom: 0.5
print.print_margin_left: 0.5
print.print_margin_right: 0.5
print.print_margin_top: 0.5
print.print_oddpages: true
print.print_orientation: 0
print.print_page_delay: 50
print.print_paper_data: 0
print.print_paper_height: 11.00
print.print_paper_name:
print.print_paper_size_unit: 0
print.print_paper_width: 8.50
print.print_resolution: 0
print.print_reversed: false
print.print_scaling: 1.00
print.print_shrink_to_fit: true
print.print_to_file: false
print.print_unwriteable_margin_bottom: 57
print.print_unwriteable_margin_left: 25
print.print_unwriteable_margin_right: 25
print.print_unwriteable_margin_top: 25
privacy.sanitize.pending: [{"id":"newtab-container","itemsToClear":[],"options":{}}]
privacy.userContext.extension: tridactyl.vim.betas@cmcaine.co.uk
security.disable_button.openCertManager: false
security.disable_button.openDeviceManager: false
security.remote_settings.intermediates.checked: 1551551815
security.sandbox.content.tempDirSuffix: {2203182c-7af9-6d45-a343-fe7767f27a0a}
security.sandbox.plugin.tempDirSuffix: 4ffc0640-5b63-0a49-b031-41bf419a0419
services.sync.declinedEngines:
services.sync.engine.addresses.available: true
services.sync.engine.bookmarks.validation.lastTime: 1551691619
services.sync.engine.passwords.validation.lastTime: 1551691619
services.sync.engine.prefs.modified: true
services.sync.lastPing: 1551691613
services.sync.lastSync: Mon Mar 04 2019 15:43:41 GMT+0200 (Eastern European Standard Time)
signon.importedFromSqlite: true
storage.vacuum.last.index: 0
storage.vacuum.last.places.sqlite: 1551641608

Important Locked Preferences
----------------------------

Places Database
---------------

JavaScript
----------

Incremental GC: true

Accessibility
-------------

Activated: false
Prevent Accessibility: 0

Library Versions
----------------

NSPR
Expected minimum version: 4.21 Beta
Version in use: 4.21 Beta

NSS
Expected minimum version: 3.43 Beta
Version in use: 3.43 Beta

NSSSMIME
Expected minimum version: 3.43 Beta
Version in use: 3.43 Beta

NSSSSL
Expected minimum version: 3.43 Beta
Version in use: 3.43 Beta

NSSUTIL
Expected minimum version: 3.43 Beta
Version in use: 3.43 Beta

Sandbox
-------

Content Process Sandbox Level: 3
Effective Content Process Sandbox Level: 3

Internationalization & Localization
-----------------------------------

Application Settings
Requested Locales: ["en-GB"]
Available Locales: ["fi","en-US"]
App Locales: ["en-US","fi"]
Regional Preferences: ["en-FI"]
Default Locale: "fi"
Operating System
System Locales: ["en-FI"]
Regional Preferences: ["en-FI"]

about:support pasted above.

Blocks: 1531867
Has Regression Range: no → yes
Component: Graphics: Text → Graphics
Flags: needinfo?(jesterking) → needinfo?(lsalzman)
Assignee: nobody → lsalzman
Status: NEW → ASSIGNED
Flags: needinfo?(lsalzman)
Priority: -- → P1
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/adf5830d08b5
don't use light-on-dark mask when font smoothing is disabled on macOS r=rhunt
Flags: needinfo?(lsalzman)
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c12a447c2785
don't use light-on-dark mask when font smoothing is disabled on macOS r=rhunt
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Duplicate of this bug: 1532544

Works great now, thanks.

Comment on attachment 9048301 [details]
Bug 1532171 - don't use light-on-dark mask when font smoothing is disabled on macOS

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Bug 1531867
  • User impact if declined: With the fix in bug 1531867, if users tweak the OS font smoothing setting to a non-default value, they will see strange colors for fonts under certain color schemes.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: Bug 1531867
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Just a fix for bug 1531867, and reporter has verified the issue is thus fixed.
  • String changes made/needed:
Attachment #9048301 - Flags: approval-mozilla-beta?

Comment on attachment 9048301 [details]
Bug 1532171 - don't use light-on-dark mask when font smoothing is disabled on macOS

Fix for recent regression, verified in nightly.
OK for uplift for beta 14.

Attachment #9048301 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
See Also: → 1541129
You need to log in before you can comment on or make changes to this bug.