1532179 - Remove unused nsMsgRDFDataSource.[h|cpp] and nsIMsgRDFDataSource.idl

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Ben Campbell]

A few RDF-related files which look like they're no longer referenced anywhere.

Comment 1

[Ben Campbell]

Attachment: rm-nsmsgrdfdatasource.patch

This compiles and builds, and passes the M-C xpcshell-test unit tests. Didn't seem worth running a try build for such vestigial code removal...

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 9048065 [details] [diff] [review]
rm-nsmsgrdfdatasource.patch

:-)

Comment 3

[:aceman]

Comment on attachment 9048065 [details] [diff] [review]
rm-nsmsgrdfdatasource.patch

Review of attachment 9048065 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, this one seems unused, in contrast to nsIRDFDataSource.

Comment 4

[Ian Neal]

Are you sure that is not used by SeaMonkey?

Comment 5

[Ben Campbell]

(In reply to Ian Neal from comment #4)

Are you sure that is not used by SeaMonkey?

I'm pretty sure it isn't. I checked by grepping for nsIMsgRDFDataSource and nsMsgRDFDataSource.
Lets say I'm 90% sure.
Anything I might have missed?

Comment 6

[Frank-Rainer Grahl (:frg)]

Anything I might have missed?

Don't think so. Even if it is used it would need to go in SeaMonkey after 2.57 (ESR60).

https://dxr.mozilla.org/comm-central/search?q=nsIMsgRDFDataSource&redirect=false
https://dxr.mozilla.org/comm-central/search?q=nsMsgRDFDataSource&redirect=false

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0663b659b91c
Remove unused nsMsgRDFDataSource.[h|cpp] and nsIMsgRDFDataSource.idl. r=aceman,jorgk