Closed Bug 1532222 Opened 5 years ago Closed 5 years ago

Remove defer usage in `devtools/client/webconsole/webconsole-ui.js`

Categories

(DevTools :: Console, enhancement, P3)

enhancement

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: nchevobbe, Unassigned, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(1 obsolete file)

devtools/client/webconsole/webconsole-ui.js#11 uses defer in destroy and _initConnection.
These 2 usages could be moved to use the standard new Promise instead.

Paarmita, would you want to work on this bug?

Flags: needinfo?(paarmita1998)

Yes, you can assign it to me.

Flags: needinfo?(paarmita1998)
Assignee: nobody → paarmita1998
Mentor: nchevobbe
Status: NEW → ASSIGNED

Checked the changes with build and linting

Hi, I would like to work on this. Should I proceed?

Flags: needinfo?(nchevobbe)
Flags: needinfo?(paarmita1998)

Hello Khyati.
The bug is currently assigned to Paarmita.

Paarmita, are you still working on this/plan to work on this?

Flags: needinfo?(nchevobbe)

(In reply to Nicolas Chevobbe from comment #5)

Hello Khyati.
The bug is currently assigned to Paarmita.

Paarmita, are you still working on this/plan to work on this?

Since she has been inactive from so many days, can I proceed?

Flags: needinfo?(nchevobbe)

it's not uncommon for people to only have a few day per month to contribute, but that doesn't mean they gave up on the bug :)
So let's wait until Paarmita answers.

I'll ping you another good first bug if you want

Flags: needinfo?(nchevobbe)

clearing assignee as we don't have news for 2 months now

Khyati are you still interested in fixing this bug?

Assignee: paarmita1998 → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(paarmita1998) → needinfo?(f20160385)

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #8)

clearing assignee as we don't have news for 2 months now

Khyati are you still interested in fixing this bug?

Yes, ofcourse.

Flags: needinfo?(f20160385)

(In reply to Khyati Agarwal from comment #9)

Yes, ofcourse.

Great! The bug is now yours. Let me know if you need anything.

Assignee: nobody → f20160385
Status: NEW → ASSIGNED

Hi Khyati. Are you still interested in fixing this bug? If not, no problem at all, just let us know so we can make this bug available to others.

Flags: needinfo?(f20160385)
Assignee: f20160385 → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(f20160385)

I'll handle this.

(In reply to r2hkri from comment #12)

I'll handle this.

Sorry, this probably will be fixed by a patch I'm working on :/

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #13)

(In reply to r2hkri from comment #12)

I'll handle this.

Sorry, this probably will be fixed by a patch I'm working on :/

No problem, thanks for letting me know.

Attachment #9049795 - Attachment is obsolete: true

there's no more defer usage in this file

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: