Closed
Bug 1532239
Opened 5 years ago
Closed 5 years ago
If S/MIME tests fails because certificates expired, test output should provide clear instructions how to refresh
Categories
(MailNews Core :: Security: S/MIME, enhancement)
MailNews Core
Security: S/MIME
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 67.0
People
(Reporter: KaiE, Assigned: KaiE)
References
Details
Attachments
(1 file, 1 obsolete file)
3.57 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
Suggested in bug 1011625 by Magnus:
If S/MIME tests fails because certificates expired, test output should provide clear instructions how to refresh
Assignee | ||
Comment 1•5 years ago
|
||
Attachment #9048139 -
Flags: review?(mkmelin+mozilla)
Comment 2•5 years ago
|
||
Comment on attachment 9048139 [details] [diff] [review] 1532239-v1.patch Review of attachment 9048139 [details] [diff] [review]: ----------------------------------------------------------------- In case we found a likely expiration, can we redo the check for a date like 1-3 days earlier, and see if that works? ::: mailnews/mime/test/unit/test_smime_decrypt.js @@ +15,4 @@ > load("../../../resources/messageModifier.js"); > load("../../../resources/messageInjection.js"); > > +class CertVerificationResultCallback { please add doc @implements nsICertVerificationCallback @@ +15,5 @@ > load("../../../resources/messageModifier.js"); > load("../../../resources/messageInjection.js"); > > +class CertVerificationResultCallback { > + constructor(resolver) { I'd make resolver named callback
Assignee | ||
Comment 3•5 years ago
|
||
In case we found a likely expiration, can we redo the check for a date like
1-3 days earlier, and see if that works?
Why? Is your intention to get a better error message, to distinguish between "certs expired" and "something else is going wrong"?
Flags: needinfo?(mkmelin+mozilla)
Comment 4•5 years ago
|
||
Yes, we don't want to have someone write it off as "oh that just expired" when there is a real issue
Flags: needinfo?(mkmelin+mozilla)
Assignee | ||
Comment 5•5 years ago
|
||
Attachment #9048139 -
Attachment is obsolete: true
Attachment #9048139 -
Flags: review?(mkmelin+mozilla)
Attachment #9048212 -
Flags: review?(mkmelin+mozilla)
Comment 6•5 years ago
|
||
Comment on attachment 9048212 [details] [diff] [review] 1532239-v2.patch Review of attachment 9048212 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thx! r=mkmelin
Attachment #9048212 -
Flags: review?(mkmelin+mozilla) → review+
Pushed by kaie@kuix.de:
https://hg.mozilla.org/comm-central/rev/91d61eb917c4
If S/MIME tests fails because certificates expired, test output should provide clear instructions how to refresh. r=mkmelin
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 67.0
You need to log in
before you can comment on or make changes to this bug.
Description
•