1532239 - If S/MIME tests fails because certificates expired, test output should provide clear instructions how to refresh

Status: RESOLVED FIXED

(MailNews Core :: Security: S/MIME, enhancement)

Description

[Kai Engert [:KaiE:]]

Suggested in bug 1011625 by Magnus:

If S/MIME tests fails because certificates expired, test output should provide clear instructions how to refresh

Comment 1

[Kai Engert [:KaiE:]]

Attachment: 1532239-v1.patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9048139 [details] [diff] [review]
1532239-v1.patch

Review of attachment 9048139 [details] [diff] [review]:
-----------------------------------------------------------------

In case we found a likely expiration, can we redo the check for a date like 1-3 days earlier, and see if that works?

::: mailnews/mime/test/unit/test_smime_decrypt.js
@@ +15,4 @@
>  load("../../../resources/messageModifier.js");
>  load("../../../resources/messageInjection.js");
>  
> +class CertVerificationResultCallback {

please add doc @implements nsICertVerificationCallback

@@ +15,5 @@
>  load("../../../resources/messageModifier.js");
>  load("../../../resources/messageInjection.js");
>  
> +class CertVerificationResultCallback {
> +  constructor(resolver) {

I'd make resolver named callback

Comment 3

[Kai Engert [:KaiE:]]

In case we found a likely expiration, can we redo the check for a date like
1-3 days earlier, and see if that works?

Why? Is your intention to get a better error message, to distinguish between "certs expired" and "something else is going wrong"?

Comment 4

[Magnus Melin [:mkmelin]]

Yes, we don't want to have someone write it off as "oh that just expired" when there is a real issue

Comment 5

[Kai Engert [:KaiE:]]

Attachment: 1532239-v2.patch

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9048212 [details] [diff] [review]
1532239-v2.patch

Review of attachment 9048212 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/91d61eb917c4
If S/MIME tests fails because certificates expired, test output should provide clear instructions how to refresh. r=mkmelin