1532297 - [wpt-sync] Sync PR 15612 - WebAuthn: Fix crash and spec compliance issues found from FIDO conformance tests

Status: RESOLVED FIXED

(Core :: DOM: Web Authentication, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 15612 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/15612
Details from upstream follow.

Callum May <[e-mail]> wrote:

WebAuthn: Fix crash and spec compliance issues found from FIDO conformance tests

• Fixed a bug related to passing in a null rp that causes the render process to crash

• Fixed two spec compliance issues related to a priori authenticating icon urls in rp.icon and user.icon.
  See https://www.w3.org/TR/webauthn/#dictionary-pkcredentialentity

Change-Id: Id3f9794deafc9f302e680b13cf3aa453e30a8506
Reviewed-on: https://chromium-review.googlesource.com/1496279
WPT-Export-Revision: f470628184fdd4991a032edc5c989943504f2da7

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=6dd5a1944fcdb1cb595083b3c135a06034837809

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=178c8c3d310a6143b4aa8639557800a3500dee87

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=a984e72571510449fdde120c449842945aebaf09

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 2 tests and 45 subtests
PASS   : 17
FAIL   : 2
TIMEOUT: 4
NOTRUN : 24

New tests that have failures or other problems:
/webauthn/createcredential-badargs-rp.https.html
    Bad rp: icon is insecure: NOTRUN
    Bad rp: rp null: FAIL
/webauthn/createcredential-badargs-user.https.html
    Bad user: icon is insecure: NOTRUN

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c17d335332f5ec86fd119f261adce7400b69d8e

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b0662de57d9
[wpt PR 15612] - WebAuthn: Fix crash and spec compliance issues found from FIDO conformance tests, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/de00ab8da208
[wpt PR 15612] - Update wpt metadata, a=testonly

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0b0662de57d9
https://hg.mozilla.org/mozilla-central/rev/de00ab8da208