Log points should show multiple values

RESOLVED FIXED in Firefox 67

Status

enhancement
P3
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: jlast, Assigned: jlast)

Tracking

unspecified
Firefox 67
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 months ago

console.log(1,2,3) will show all three values. Similarly the log point 1,2,3 should show all three values.

1526557 changed the default behavior from using console.log to evaluating the expression and using the return value.

One of the common usecases for multiple values is a log with a label and a value. e.g. addBreakpoint ${bp}

Assignee

Updated

3 months ago
Severity: normal → enhancement
Priority: -- → P3
Assignee

Comment 1

3 months ago

we could get this behavior by using an array to capture all of the values [${log}]

https://gist.github.com/e07155cced2f5f906c64010c2cb781ba

This could potentially have some issues in terms of error messages, but overall is fine.

This is the behavior from other log point implementations as well and helps to avoid string concatenations/templating, so +1 to align this; maybe even making this a stretch goal for M1.

Comment 4

2 months ago
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c6fc5c010f4
Log points should show multiple values. r=bhackett

Comment 5

2 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Assignee: nobody → jlaster
Blocks: logpoints-m1
No longer blocks: dbg-logpoints
You need to log in before you can comment on or make changes to this bug.